incubator-xtable icon indicating copy to clipboard operation
incubator-xtable copied to clipboard

Add record count to OneData File with Delta version upgrade.

Open vamshigv opened this issue 2 years ago • 8 comments

Currently with delta version 2.0.2 we had remove recount count as the current version does not provide it. Add it back during upgrade.

vamshigv avatar Oct 24 '23 04:10 vamshigv

We are now on Delta 2.4.X so this can be easily done. Labeling as a "good first issue" in case anyone wants to pick it up.

the-other-tim-brown avatar Mar 03 '24 03:03 the-other-tim-brown

We are now on Delta 2.4.X so this can be easily done. Labeling as a "good first issue" in case anyone wants to pick it up. as part of this change do we want to remove the record count from deltaActionsConverter as it was workaround

gzagarwal avatar Mar 15 '24 14:03 gzagarwal

Also the change is not present in the github code in main branch the code is changed in "core/src/main/java/io/onetable/delta/DeltaActionsConverter.java" https://github.com/apache/incubator-xtable/blob/main/core/src/main/java/org/apache/xtable/delta/DeltaActionsConverter.java

gzagarwal avatar Mar 15 '24 14:03 gzagarwal

@gzagarwal The history may be hard to find but there is some method we can now call to get the row count if I am remembering correctly instead of computing it ourselves.

the-other-tim-brown avatar Mar 25 '24 15:03 the-other-tim-brown

@gzagarwal The history may be hard to find but there is some method we can now call to get the row count if I am remembering correctly instead of computing it ourselves.

Sure @the-other-tim-brown let me look into the xtable code and test case. if i find some thing then will ask to assign the jira.

gzagarwal avatar Mar 25 '24 16:03 gzagarwal

@gzagarwal awesome! We're excited to have you start contributing!

the-other-tim-brown avatar Mar 25 '24 17:03 the-other-tim-brown

Hi @the-other-tim-brown,

I really like this project! I wanted to take a look at something to pick up get used to things.

I came across this issue and I think it hasn't been closed yet. I found these two commits, so the previous method to get the count is the second(I think?) https://github.com/apache/incubator-xtable/commit/cdc0422cbe86107b6e752562f1b0395e9a5cc728

https://github.com/apache/incubator-xtable/commit/e48374c998a39b24deb68e44a4a765e9c4da5fb4

prithvijitguha avatar Jul 03 '24 16:07 prithvijitguha

Hi @the-other-tim-brown,

I really like this project! I wanted to take a look at something to pick up get used to things.

I came across this issue and I think it hasn't been closed yet. I found these two commits, so the previous method to get the count is the second(I think?) cdc0422

e48374c

@prithvijitguha there should be a way to get the record count directly from the delta objects after upgrading. Take a look and raise a PR if you would like!

the-other-tim-brown avatar Jul 03 '24 23:07 the-other-tim-brown

Hi, Is someone working on it? I am new to this project and would like to get started.

Reactor11 avatar Oct 10 '24 05:10 Reactor11

@Reactor11 I don't think anyone is so I have assigned you the issue. Let me know if you need any help getting started!

the-other-tim-brown avatar Oct 10 '24 19:10 the-other-tim-brown

Hi @the-other-tim-brown - Thanks for assigning me this issues, I would need help in getting started! Let me know how can we connect for some time perhaps!

Reactor11 avatar Oct 12 '24 08:10 Reactor11