incubator-samoa icon indicating copy to clipboard operation
incubator-samoa copied to clipboard
verified publisher icon apache

Code cleanups and warnings

Open smarthi opened this issue 10 years ago • 4 comments

smarthi avatar Dec 23 '15 01:12 smarthi

Thanks for the nice cleanup, +1. Will wait for a second review before committing.

gdfm avatar Jan 31 '16 13:01 gdfm

I like very much the cleanup. However, I see some changes in the code of RandomRBFGeneratorEvents, Can you explain why these changes are needed? Thanks!

abifet avatar Feb 03 '16 10:02 abifet

I like very much the cleanup. However, I see some changes in the code of RandomRBFGeneratorEvents, Can you explain why these changes are needed? Thanks!

@abifet It seems to me that the code changes you mentioned are the removal of dead code branches (i.e. the conditions are impossible to satisfy).

csterling avatar Nov 18 '19 21:11 csterling

@abifet It seems to me that the code changes you mentioned are the removal of dead code branches (i.e. the conditions are impossible to satisfy).

@csterling Thanks! +1

abifet avatar Nov 18 '19 22:11 abifet