incubator-graphar icon indicating copy to clipboard operation
incubator-graphar copied to clipboard

[WIP] add remove vertex edge, TODO: tests

Open sapienza88 opened this issue 4 months ago • 6 comments

Reason for this PR

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

sapienza88 avatar Sep 22 '25 19:09 sapienza88

Codecov Report

:x: Patch coverage is 48.38710% with 16 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 76.51%. Comparing base (b7768ad) to head (03c7c42). :warning: Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...c/main/java/org/apache/graphar/info/GraphInfo.java 48.38% 14 Missing and 2 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #773      +/-   ##
============================================
+ Coverage     76.48%   76.51%   +0.02%     
- Complexity      535      564      +29     
============================================
  Files            82       83       +1     
  Lines          8638     8720      +82     
  Branches       1001     1011      +10     
============================================
+ Hits           6607     6672      +65     
- Misses         1815     1828      +13     
- Partials        216      220       +4     
Flag Coverage Δ
java-info 81.79% <48.38%> (-0.21%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Sep 22 '25 19:09 codecov-commenter

@yangxk1 Do we need to consider the adjacency list when deleting a vertex/edge? where do you test addVertex() in GraphInfo.java ?

sapienza88 avatar Sep 22 '25 19:09 sapienza88

Do we need to consider the adjacency list when deleting a vertex/edge?

Do you mean that delete adjacency list in edgeInfo?

where do you test addVertex() in GraphInfo.java ?

I don't think we tested addVertex, can you add tests for them in GraphInfoTest/EdgeInfoTest/VertexInfoTest by the way?

yangxk1 avatar Sep 23 '25 02:09 yangxk1

Do we need to consider the adjacency list when deleting a vertex/edge?

Do you mean that delete adjacency list in edgeInfo?

where do you test addVertex() in GraphInfo.java ?

I don't think we tested addVertex, can you add tests for them in GraphInfoTest/EdgeInfoTest/VertexInfoTest by the way?

Ok, where is the yaml file, to load a sample testing graph from which i can add or remove vertex and validate?

sapienza88 avatar Sep 23 '25 08:09 sapienza88

In GraphInfoTest::setup, a GraphInfo has been loaded and parsed, you can test method by it. https://github.com/apache/incubator-graphar/blob/b7768ad09ece6941a32e65e436f765fdf3c1a0fc/maven-projects/info/src/test/java/org/apache/graphar/info/GraphInfoTest.java#L39

yangxk1 avatar Sep 23 '25 09:09 yangxk1

@unical1988 , please note that runs git submodule update --remote use the latest test data

yangxk1 avatar Sep 26 '25 06:09 yangxk1