incubator-graphar icon indicating copy to clipboard operation
incubator-graphar copied to clipboard

updating docs for removing edge or vertex in Java in impl-stats

Open sapienza88 opened this issue 7 months ago • 7 comments

This open PR is for updating the docs for newly implemented graph features (graph vertex and edge removal) in Java

sapienza88 avatar Jul 04 '25 03:07 sapienza88

@yangxk1 pls proceed to reviewing my past PRs

sapienza88 avatar Jul 14 '25 11:07 sapienza88

@unical1988 , the docs should be modified after the code pr merge, otherwise it will cause confusion. To modify the PR of the code, please make sure that they can pass the CI workflows :)

yangxk1 avatar Jul 14 '25 11:07 yangxk1

@unical1988 , the docs should be modified after the code pr merge, otherwise it will cause confusion. To modify the PR of the code, please make sure that they can pass the CI workflows :)

aside from can pass the CI workflows, pls review the PRs , I am not writing for myself the code but for the project, CI comes after the code is discussed here and reviewer

sapienza88 avatar Jul 14 '25 11:07 sapienza88

@unical1988 , the docs should be modified after the code pr merge, otherwise it will cause confusion. To modify the PR of the code, please make sure that they can pass the CI workflows :)

aside from can pass the CI workflows, pls review the PRs , I am not writing for myself the code but for the project, CI comes after the code is discussed here and reviewer

For example, the following ci:

https://github.com/apache/incubator-graphar/actions/runs/15913059612/job/44900162946?pr=711

https://github.com/apache/incubator-graphar/actions/runs/16003204977/job/45210287183?pr=714

yangxk1 avatar Jul 14 '25 11:07 yangxk1

@unical1988 , the docs should be modified after the code pr merge, otherwise it will cause confusion. To modify the PR of the code, please make sure that they can pass the CI workflows :)

aside from can pass the CI workflows, pls review the PRs , I am not writing for myself the code but for the project, CI comes after the code is discussed here and reviewer

For example, the following ci:

https://github.com/apache/incubator-graphar/actions/runs/15913059612/job/44900162946?pr=711

https://github.com/apache/incubator-graphar/actions/runs/16003204977/job/45210287183?pr=714

These come after reviewing the code! (as a matter of fact these are formatting related issues easily solved with spotless:apply of maven.

sapienza88 avatar Jul 14 '25 11:07 sapienza88

rerun mvn spotless:apply and push to your branch, ci will be triggered again :)

yangxk1 avatar Jul 14 '25 11:07 yangxk1

rerun mvn spotless:apply and push to your branch, ci will be triggered again :)

I will do that but pls review the other PRs as well so we can merge them

sapienza88 avatar Jul 14 '25 11:07 sapienza88