fix: Consider first comment to be of type Review

[tcarac]

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

• [X] I have read through the Contributing Documentation.
• [] I have added relevant tests.
• [X] I have added relevant documentation.
• [X] I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

Takes into a account Pr Type to determine if it should be considered as the first Pr in pickup time

Does this close any open issues?

https://github.com/apache/incubator-devlake/discussions/8317

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

[tcarac]

Don't see any specific related tests to this function or classes. Are these to be considered part of the csv testing within dataflow ?

[klesh]

It seems that only the Github plugin respects this type field, which means this patch may not work as expected on other plugins. I think this issue could be addressed in the following ways:

1. Update all other plugins to fill in this field.
2. Accept both REVIEW and an empty string for the type column.

[klesh]

Hi, @tcarac e2e tests is failing, I think the csv files located in https://github.com/apache/incubator-devlake/tree/main/backend/plugins/dora/e2e/change_lead_time need to be updated, try adding type column to pull_request_comments.csv?

[tcarac]

Hi, @tcarac e2e tests is failing, I think the csv files located in https://github.com/apache/incubator-devlake/tree/main/backend/plugins/dora/e2e/change_lead_time need to be updated, try adding type column to pull_request_comments.csv?

@klesh This is done. Please lmk if we need anything else and TY for your support in this.

[klesh]

Thanks for updating the files. and seems like the e2e-tests are still failing on PG database, not sure why though, maybe the column is NULL instead of empty?

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

[github-actions[bot]]

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.