[Bug][api] Incorrect Rate Limit Value Returned in API Response for Connections
Search before asking
- [X] I had searched in the issues and found no similar issues.
What happened
Currently, when the connection API request rate limit is not set in DevLake, the platform uses a default value. However, the API response for the "connection" endpoint returns a rate_limit value of 0, which leads to a discrepancy between the displayed rate limit and the actual rate limit being executed. This inconsistency can confuse users and provide inaccurate information about their rate limits.
What do you expect to happen
When the API returns a "connection" object, it is expected that the rate_limit value accurately represents the current rate limit being enforced for that connection. This ensures transparency and allows users to have an accurate understanding of their rate limits.
How to reproduce
- Set up a DevLake instance and configure it with third-party platforms(eg: jira) for data collection.
- Make sure the connection API rate limit is not explicitly set for connection.
- Send a request to the API to retrieve the connection information.
- Examine the response and observe that the rate_limit value returned for the connection is 0, regardless of the actual rate limit being enforced.
Anything else
Please let me know if there's anything else you'd like to include or if you need further assistance.
Version
release-v0.17
Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
I'll take this issue and fix it. All plugins have their own default rate limit value, but the value in database is zero if user doesn't set it, which is unexpected.
This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.
This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.
This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.
This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.