incubator-answer icon indicating copy to clipboard operation
incubator-answer copied to clipboard

installing plugins will reset UI to default and not reflect already present changes made

Open ionics opened this issue 1 year ago • 4 comments

Describe the bug

  • UI changes reflected after "make build"
  • UI changes lost after "./answer build --with example-plugin"

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

  1. ./answer init -C answer-data/
  2. ./answer run -C answer-data/ => UI changes still present ✅ This is what we want.
  3. Install plugin via cmd: ./answer build --with github.com/apache/incubator-answer-plugins/search-elasticsearch --with github.com/apache/incubator-answer-plugins/cache-redis
  4. Restart app: ./answer run -C answer-data/ => Plugins got installed, but UI changes lost and set to default. 💥

Installing plugins will reset UI to default.

Expected behavior

Installing plugins should not reset UI to default.

Platform

Distributor ID: Ubuntu Description: Ubuntu 22.04.4 LTS Release: 22.04 Codename: jammy

answer version 1.3.5 revision: 3ce69256 build time: 1721985092

ionics avatar Jul 26 '24 09:07 ionics

@ionics In step3, you can try to use ANSWER_MODULE=/your-local-answer-source-code-path/incubator-answer ./answer build --with .....

It will use your local code instead of the remote code to build.

LinkinStars avatar Jul 30 '24 08:07 LinkinStars

@LinkinStars what remote code? also, @ionics can you describe what UI changes you made?

zahash avatar Aug 28 '24 18:08 zahash

@LinkinStars what remote code? also, @ionics can you describe what UI changes you made?

The remote code is the code that in github repo. Setting the ANSWER_MODULE environment variable allows the user to compile the plugin from local code. Because this user has modified the local UI code, it needs to be built from local.

LinkinStars avatar Aug 29 '24 02:08 LinkinStars

@zahash with UI changes i was refering to changes to CSS and style code.

changes present with "run command" but gone after installing plugin via cmd:

./answer build --with github.com/apache/incubator-answer-plugins/search-elasticsearch --with github.com/apache/incubator-answer-plugins/cache-redis

check my post above.

Kind regards.

ionics avatar Oct 18 '24 06:10 ionics