iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard

Support for TIME, TIMESTAMPNTZ_NANO, UUID types in Inclusive Metrics Evaluator

Open manirajv06 opened this issue 7 months ago • 1 comments

Added support for following types in VariantExpressionUtil:

PhysicalType.TIME PhysicalType.TIMESTAMPNTZ_NANO PhysicalType.TIMESTAMPTZ_NANO PhysicalType.UUID

In addition to covering unit tests for above types, added tests for TIMESTAMPNTZ and TIMESTAMPTZ types as well.

manirajv06 avatar May 31 '25 09:05 manirajv06

@aihuaxu @RussellSpitzer Can you please review?

manirajv06 avatar May 31 '25 09:05 manirajv06

@rdblue Thank you for setting up the direction on this. Incorporated your feedback. Please check.

manirajv06 avatar Jul 30 '25 17:07 manirajv06

@aihuaxu @rdblue Can you please take a look?

manirajv06 avatar Sep 15 '25 16:09 manirajv06

@aihuaxu We are very close to completion. Do you have anymore feedback? If not, Can we request @RussellSpitzer to commit?

manirajv06 avatar Sep 24 '25 17:09 manirajv06

@RussellSpitzer Can we get this in? Thanks.

manirajv06 avatar Oct 08 '25 03:10 manirajv06

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Nov 08 '25 00:11 github-actions[bot]

@RussellSpitzer Can we merge the changes? @aihuaxu had already approved this.

manirajv06 avatar Nov 11 '25 15:11 manirajv06

@huaxingao Can you also take a look at this change?

aihuaxu avatar Dec 05 '25 04:12 aihuaxu

Thanks @manirajv06 for the PR! The change looks good to me.

huaxingao avatar Dec 07 '25 03:12 huaxingao

Thanks @manirajv06 for the PR! I will leave the PR open for a couple of more days in case others want to review.

huaxingao avatar Dec 08 '25 17:12 huaxingao

Thanks @manirajv06 for the PR! Thanks @aihuaxu @rdblue for the review!

huaxingao avatar Dec 11 '25 17:12 huaxingao