iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard

Core: delete temp metadata file when version already exists

Open leesf opened this issue 1 year ago • 1 comments

When using HadoopCatalog, renameToFinal would fail with version already exists exception, we should also delete the temp metadata file in this case.

leesf avatar Oct 18 '24 03:10 leesf

@rdblue please help to review this PR, thanks.

leesf avatar Oct 18 '24 05:10 leesf

This makes sense. @leesf Could you add a test so we don't break this in the future?

@Fokko Added check to the existing UT with dist file already exists failure.

leesf avatar Oct 30 '24 05:10 leesf

@leesf Thanks! Can you run ./gradlew :iceberg-core:spotlessApply to fix the formatting? Thanks!

Fokko avatar Oct 30 '24 06:10 Fokko

./gradlew :iceberg-core:spotlessApply

@Fokko Done and thanks.

leesf avatar Oct 30 '24 07:10 leesf

@Fokko I think the PR to good the merge, thanks.

leesf avatar Oct 31 '24 12:10 leesf

@Fokko hi, anything need to resolve here to merge the PR?

leesf avatar Nov 19 '24 13:11 leesf

@nastra I pushed an update to fix the ut updated by your push.

leesf avatar Nov 20 '24 01:11 leesf