iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard
verified publisher icon apache

Updating SparkScan to only read Apache DataSketches

Open jeesou opened this issue 1 year ago • 1 comments

Closes #11034

jeesou avatar Aug 28 '24 11:08 jeesou

Hi @huaxingao, @karuppayya kindly review the PR.

jeesou avatar Aug 28 '24 11:08 jeesou

Hi Adding an enhancement in test case -

For no stats scenario also, we were traversing over the expectedNDVs Map, which was empty, and thus the Assert was never reached, and it was not properly tested whether no statistics are generated or whether the statistics generated were null or not.

jeesou avatar Aug 29 '24 20:08 jeesou

Hi @karuppayya , @aokolnychyi , @huaxingao kindly review this PR once.

jeesou avatar Sep 05 '24 04:09 jeesou

@karuppayya @huaxingao @szehon-ho can you please help review this.

guykhazma avatar Sep 14 '24 12:09 guykhazma

Hi @aokolnychyi could you please help review this PR.

jeesou avatar Sep 23 '24 17:09 jeesou

I'll check tomorrow. Sorry for the delay!

aokolnychyi avatar Sep 24 '24 05:09 aokolnychyi

Hi @aokolnychyi could you please help review this PR once.

jeesou avatar Oct 08 '24 06:10 jeesou

Thanks @jeesou for the PR, @aokolnychyi , @karuppayya , @huaxingao , @guykhazma all for reviewing.

RussellSpitzer avatar Oct 16 '24 22:10 RussellSpitzer