iceberg-rust icon indicating copy to clipboard operation
iceberg-rust copied to clipboard
verified publisher icon apache

Implement BoundPredicateVisitor trait for ManifestFilterVisitor

Open s-akhtar-baig opened this issue 1 year ago • 1 comments

GitHub issue: https://github.com/apache/iceberg-rust/issues/350

Description: ManifestEvaluator was implemented in https://github.com/apache/iceberg-rust/pull/322 whereas some functions were unimplemented. This PR implements the remaining functions and adds most of the Python unit tests.

Testing: Added new unit tests.

s-akhtar-baig avatar May 09 '24 19:05 s-akhtar-baig

@sdd, thank you for reviewing the changes and providing references! I have modified my code based on your suggestions. Please take a look and let me know if I miss anything.

s-akhtar-baig avatar May 10 '24 20:05 s-akhtar-baig

@liurenjie1024 @marvinlanhenke @sdd, thank you for reviewing these changes and for your feedback! Greatly appreciated!

I have pushed the required changes. Please let me know if I missed anything, thanks!

s-akhtar-baig avatar Jun 10 '24 17:06 s-akhtar-baig

Hi @liurenjie1024 - sorry to pester you but are you able to re-review this please? It's the last major piece of the puzzle on the read side.

sdd avatar Jun 11 '24 18:06 sdd

Hi @liurenjie1024 - sorry to pester you but are you able to re-review this please? It's the last major piece of the puzzle on the read side.

Hi, @sdd Sorry for delay. I'll review it today.

liurenjie1024 avatar Jun 13 '24 01:06 liurenjie1024

cc @Fokko Do you want to take a review for this? I see you assigned yourself for review.

liurenjie1024 avatar Jun 13 '24 13:06 liurenjie1024