iceberg-rust icon indicating copy to clipboard operation
iceberg-rust copied to clipboard
verified publisher icon apache

Add `InclusiveMetricsEvaluator`

Open sdd opened this issue 1 year ago • 2 comments

InclusiveMetricsEvaluator is used inside table scans to filter DataFile entries within a Manifest, rejecting any of them if their metrics indicate that they cannot contain any rows that match the predicate filter.

Comments / suggestions are welcome.

Implements https://github.com/apache/iceberg-rust/issues/127

sdd avatar Apr 23 '24 19:04 sdd

@marvinlanhenke Thanks for taking the time for the great review. Have addressed your raised points. I'm adding tests based on https://github.com/apache/iceberg/blob/main/api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java and will submit them over the next day or so, once complete.

sdd avatar Apr 29 '24 06:04 sdd

FAO @Fokko @liurenjie1024 @marvinlanhenke:

I've finished adding tests for this - it's ready for review, PTAL! 😄

sdd avatar May 04 '24 19:05 sdd