iceberg-go icon indicating copy to clipboard operation
iceberg-go copied to clipboard

feat: Adding literals

Open zeroshade opened this issue 1 year ago • 2 comments

After about 5 or 6 iterations of playing with how to represent expressions to start working on scan planning, I've finally settled on something I like!!

Rather than a huge code dump, I've broken it out into smaller successive PRs so that it is easier to review. This PR contains the definitions for representing Literals, which will then get utilized in constructing BooleanExpressions and so on.

zeroshade avatar May 09 '24 19:05 zeroshade

CC @Fokko @nastra @wolfeidau

zeroshade avatar May 09 '24 19:05 zeroshade

@zeroshade this is a considerable amount of work, I really need to learn more about the internals of iceberg, mostly working to understand the metadata.

Looks great, nothing stands out as issues to me.

wolfeidau avatar May 11 '24 04:05 wolfeidau

@zeroshade Thanks! Can you fix the conflicts?

Fokko avatar May 27 '24 06:05 Fokko

updated and fixed the conflicts @Fokko! :smile:

zeroshade avatar May 28 '24 14:05 zeroshade

@zeroshade Awesome, let's get this in! 🚀

Fokko avatar May 28 '24 14:05 Fokko