hudi icon indicating copy to clipboard operation
hudi copied to clipboard

optimized code in the class of HoodieFlinkStreamer

Open linfey90 opened this issue 3 years ago • 1 comments

Change Logs

Before that, the code 'FlinkStreamerConfig.toFlinkConfig(cfg)' will be called twice. It's mostly misleading and the same thing both times.

Impact

Describe any public API or user-facing feature change or any performance impact.

**Risk level: none

Contributor's checklist

  • [ ] Read through contributor's guide
  • [ ] Change Logs and Impact were stated clearly
  • [ ] Adequate tests were added if applicable
  • [ ] CI passed

linfey90 avatar Aug 11 '22 11:08 linfey90

CI report:

  • 45c1b16068742b5d54c86df8cb6be2281a55af0d Azure: FAILURE
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Aug 11 '22 14:08 hudi-bot

Thanks for the contribution @linfey90 , it is a valid fix, can you fire a JIRA issue here: https://issues.apache.org/jira/projects/HUDI/issues/HUDI-4579?filter=allopenissues

and change the commit title to the form:

[HUDI-${JIRA_ISSUE_ID}] ${your commit message}

danny0405 avatar Aug 12 '22 01:08 danny0405

Thanks for the contribution @linfey90 , it is a valid fix, can you fire a JIRA issue here: https://issues.apache.org/jira/projects/HUDI/issues/HUDI-4579?filter=allopenissues

and change the commit title to the form:

[HUDI-${JIRA_ISSUE_ID}] ${your commit message}

I did it and I'll pay attention next time,thanks!

linfey90 avatar Aug 12 '22 02:08 linfey90

The failed test case: ITTestHoodieFlinkCompactor.testHoodieFlinkCompactor seems flaky, should not be affected by this patch, would merge the PR soon ~

danny0405 avatar Aug 12 '22 03:08 danny0405