apache
add auto col cast in MergeIntoHoodieTableCommand
Change Logs
https://github.com/apache/hudi/issues/6354 Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level: none | low | medium | high
Choose one. If medium or high, explain what verification was done to mitigate the risks.
Contributor's checklist
- [ ] Read through contributor's guide
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
@alexeykudinkin can you recommend a plan: land this alone or include the fix in https://github.com/apache/hudi/pull/6361 ? both are for https://github.com/apache/hudi/issues/6354
@xushiyan i don't think we will be able to land this as is, as it might heavily restrict usability of the MERGE INTO
@fengjian428 please attach corresponding JIRA, and update PR description
@fengjian428 please attach corresponding JIRA, and update PR description
done
@fengjian428 let's also add a test for this issue
at what level? I feel it looks redundant if create a test only to check the payload class, WDYT?
@fengjian428 we should add additional case for Merge Into statement tests, where we specify non-default record-payload and make sure that it still works as expected. This is a regression, so we'd add a test for it
@fengjian428 we should add additional case for Merge Into statement tests, where we specify non-default record-payload and make sure that it still works as expected. This is a regression, so we'd add a test for it
ok, add a ut to cover https://github.com/apache/hudi/issues/6354
CI is green:
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=11905&view=results
