hudi icon indicating copy to clipboard operation
hudi copied to clipboard

[HUDI-7596] Enable Jacoco code coverage report across multiple modules

Open danny0405 opened this issue 1 year ago • 4 comments

Change Logs

Enable the Jacoco code coverage for Azure CI.

Impact

none

Risk level (write none, low medium or high below)

none

Documentation Update

none

Contributor's checklist

  • [ ] Read through contributor's guide
  • [ ] Change Logs and Impact were stated clearly
  • [ ] Adequate tests were added if applicable
  • [ ] CI passed

danny0405 avatar Apr 23 '24 02:04 danny0405

@hudi-bot run azure

danny0405 avatar Apr 24 '24 01:04 danny0405

CI report:

  • 39c44a33eaae3bc17270cec93536ce727daacd98 UNKNOWN
  • d329d241fef55c438e72343e4564671df92befff UNKNOWN
  • 7d82c286ff67aa8a745651bf23cdb25b161b7919 Azure: SUCCESS
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar Apr 25 '24 13:04 hudi-bot

I notice that the azure CI results are now grouped by folders? and could we show an example to illustrate that cross module FT coverage is now factored in?

Could we fix these before landing?

vinothchandar avatar Apr 29 '24 16:04 vinothchandar

I notice that the azure CI results are now grouped by folders? and could we show an example to illustrate that cross module FT coverage is now factored in?

Could we fix these before landing?

In order to make the cross module FT coverage work, we need to:

  1. add a new separate module that including dependencies of all the modules that we want to report;
  2. run all the module tests in one shot and there is no way to run specific module with -pl option;

Our CI tests are split into 6 jobs with each covering different modules, which is not suitable for the jacoco report-aggregate goal.

danny0405 avatar Apr 30 '24 00:04 danny0405

Closing this PR for now since Jacoco coverage report does not fit into our CI job running model.

yihua avatar Sep 19 '24 18:09 yihua