hudi icon indicating copy to clipboard operation
hudi copied to clipboard

[HUDI-7526] Fix constructors for bulkinsert sort partitioners to ensure we could use it as user defined partitioners

Open wombatu-kun opened this issue 1 year ago • 2 comments

Change Logs

Our constructor for user defined sort partitioner takes in write config, while some of the partitioners used in out of the box sort mode, does not account for it.
Lets fix the sort partitioners to ensure anything can be used as user defined partitioners. For eg, NoneSortMode does not have a constructor that takes in write config

Impact

none

Risk level (write none, low medium or high below)

none

Documentation Update

none

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the instruction to make changes to the website.

Contributor's checklist

  • [ ] Read through contributor's guide
  • [ ] Change Logs and Impact were stated clearly
  • [ ] Adequate tests were added if applicable
  • [ ] CI passed

wombatu-kun avatar Mar 31 '24 14:03 wombatu-kun

@nsivabalan Hi! Sorry to bother you, but you are reporter of this task. Could you please review my PR?
Or close the PR if i totally misunderstood the task and did it wrong.

wombatu-kun avatar Apr 16 '24 02:04 wombatu-kun

CI report:

  • 55fb13f601452d13f9ef2984e8ecef3ea95d7de6 Azure: SUCCESS
Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

hudi-bot avatar May 15 '24 06:05 hudi-bot