apache
[HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline
Change Logs
Moved createNewInstantTime out of HoodieActiveTimeline (to HoodieTimeline)
Impact
none
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
- The config description must be updated if new configs are added or the default value of the configs are changed
- Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the instruction to make changes to the website.
Contributor's checklist
- [ ] Read through contributor's guide
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
CI report:
- 237c5cdda3c87fec59247bb403c202d39bc5cdca Azure: SUCCESS
Bot commands
@hudi-bot supports the following commands:-
@hudi-bot run azurere-run the last Azure build
I don't know exactly, I'm not the reporter of this improvement in ASF Jira (it is Hui An). I suppose his purpose was to extract such a common utility code from HoodieActiveTimeline class to ease it's huge and complex logic a little bit.
@boneanxs Can you help for the review and clarify the initiative aim of the task?
@boneanxs Can you help for the review and clarify the initiative aim of the task?
Hey @danny0405 @wombatu-kun, sorry for misunderstanding. The intention of this issue is to moving createNewInstantTime to TimeGenerator or somewhere else as a instance method since createNewInstantTime in HoodieActiveTimeline is a static method and requires to pass HadoopConf and HoodieTimeGeneratorConfig(now is TimeGenerator) every time.
But after some codes refine of #9617(we hide createNewInstantTime to HoodieTableMetaClient and BaseHoodieClient), it looks quite clean now, not sure we still need this.
