hudi-rs icon indicating copy to clipboard operation
hudi-rs copied to clipboard

refactor: define Hudi error types across hudi-core

Open gohalo opened this issue 1 year ago • 2 comments

Description

Use thiserror instead of anyhow to define the error for hudi-core crate.

Currently, work in progress.

#72

How are the changes test-covered

  • [x] N/A
  • [ ] Automated tests (unit and/or integration tests)
  • [ ] Manual tests
    • [ ] Details are described below

gohalo avatar Aug 31 '24 02:08 gohalo

@xushiyan @codope Hope this codes could be reviewed as soon as possible, because it refact the core crate, and almost every new merged code should refact again. 😊

gohalo avatar Sep 10 '24 12:09 gohalo

Codecov Report

Attention: Patch coverage is 71.92982% with 32 lines in your changes missing coverage. Please review.

Project coverage is 90.53%. Comparing base (a2738da) to head (02c659b). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/storage/utils.rs 57.14% 6 Missing :warning:
crates/core/src/table/builder.rs 37.50% 5 Missing :warning:
python/src/internal.rs 0.00% 5 Missing :warning:
crates/core/src/table/mod.rs 20.00% 4 Missing :warning:
crates/core/src/table/partition.rs 55.55% 4 Missing :warning:
crates/core/src/storage/mod.rs 76.92% 3 Missing :warning:
crates/core/src/config/internal.rs 60.00% 2 Missing :warning:
crates/core/src/config/table.rs 93.54% 2 Missing :warning:
crates/core/src/table/timeline.rs 91.66% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   91.78%   90.53%   -1.26%     
==========================================
  Files          20       21       +1     
  Lines         962     1004      +42     
==========================================
+ Hits          883      909      +26     
- Misses         79       95      +16     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 11 '24 05:09 codecov[bot]

@gohalo any plan to resume the work here by resolving conflicts first? we've cut release branch so master won't have much changes for some time.

xushiyan avatar Nov 20 '24 14:11 xushiyan

OK, will fix that next week

gohalo avatar Nov 21 '24 02:11 gohalo

@gohalo do you have time to resume work on this? in case you're occupied, maybe @TheR1sing3un could take this over? as this is more of a foundational work, we want to move forward sooner, ideally land this within the next 7 days. thanks!

xushiyan avatar Nov 30 '24 20:11 xushiyan

@gohalo do you have time to resume work on this? in case you're occupied, maybe @TheR1sing3un could take this over? as this is more of a foundational work, we want to move forward sooner, ideally land this within the next 7 days. thanks!

working on that, still have some conflicts to fix now

gohalo avatar Dec 02 '24 01:12 gohalo

@xushiyan the conflicts have fixed, i will check the coverage recently, you could review the code first.

gohalo avatar Dec 03 '24 07:12 gohalo

@xushiyan the conflicts have fixed, i will check the coverage recently, you could review the code first.

Thanks for the fix! will go through this today.

xushiyan avatar Dec 03 '24 18:12 xushiyan

I'll work on a follow up PR to get the coverage level back. merging it now.

xushiyan avatar Dec 05 '24 01:12 xushiyan