refactor: define Hudi error types across hudi-core
Description
Use thiserror instead of anyhow to define the error for hudi-core crate.
Currently, work in progress.
#72
How are the changes test-covered
- [x] N/A
- [ ] Automated tests (unit and/or integration tests)
- [ ] Manual tests
- [ ] Details are described below
@xushiyan @codope Hope this codes could be reviewed as soon as possible, because it refact the core crate, and almost every new merged code should refact again. 😊
Codecov Report
Attention: Patch coverage is 71.92982% with 32 lines in your changes missing coverage. Please review.
Project coverage is 90.53%. Comparing base (
a2738da) to head (02c659b). Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 91.78% 90.53% -1.26%
==========================================
Files 20 21 +1
Lines 962 1004 +42
==========================================
+ Hits 883 909 +26
- Misses 79 95 +16
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@gohalo any plan to resume the work here by resolving conflicts first? we've cut release branch so master won't have much changes for some time.
OK, will fix that next week
@gohalo do you have time to resume work on this? in case you're occupied, maybe @TheR1sing3un could take this over? as this is more of a foundational work, we want to move forward sooner, ideally land this within the next 7 days. thanks!
@gohalo do you have time to resume work on this? in case you're occupied, maybe @TheR1sing3un could take this over? as this is more of a foundational work, we want to move forward sooner, ideally land this within the next 7 days. thanks!
working on that, still have some conflicts to fix now
@xushiyan the conflicts have fixed, i will check the coverage recently, you could review the code first.
@xushiyan the conflicts have fixed, i will check the coverage recently, you could review the code first.
Thanks for the fix! will go through this today.
I'll work on a follow up PR to get the coverage level back. merging it now.