hive
hive copied to clipboard
HIVE-29191: Gracefully Handle Removed Configuration Properties in Hiv…
…e 4 to Avoid Job Failures
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
Reviewer's guide (collapsed on small PRs)
Reviewer's Guide
Adds a new system session property “max_split_preload_per_driver” by declaring its constant, registering it with a default value, and exposing an accessor method.
Class diagram for updated SystemSessionProperties
classDiagram
class SystemSessionProperties {
+static final String MAX_SPLIT_PRELOAD_PER_DRIVER
+static int getMaxSplitPreloadPerDriver(Session session)
}
SystemSessionProperties --> Session : uses
class Session {
+getSystemProperty(String, Class)
}
File-Level Changes
| Change | Details | Files |
|---|---|---|
| Introduce max_split_preload_per_driver system session property |
|
presto-main-base/src/main/java/com/facebook/presto/SystemSessionProperties.java |
Tips and commands
Interacting with Sourcery
-
Trigger a new review: Comment
@sourcery-ai reviewon the pull request. - Continue discussions: Reply directly to Sourcery's review comments.
-
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with
@sourcery-ai issueto create an issue from it. -
Generate a pull request title: Write
@sourcery-aianywhere in the pull request title to generate a title at any time. You can also comment@sourcery-ai titleon the pull request to (re-)generate the title at any time. -
Generate a pull request summary: Write
@sourcery-ai summaryanywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment@sourcery-ai summaryon the pull request to (re-)generate the summary at any time. -
Generate reviewer's guide: Comment
@sourcery-ai guideon the pull request to (re-)generate the reviewer's guide at any time. -
Resolve all Sourcery comments: Comment
@sourcery-ai resolveon the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore. -
Dismiss all Sourcery reviews: Comment
@sourcery-ai dismisson the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment@sourcery-ai reviewto trigger a new review!
Customizing Your Experience
Access your dashboard to:
- Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
- Change the review language.
- Add, remove or edit custom review instructions.
- Adjust other review settings.
Getting Help
- Contact our support team for questions or feedback.
- Visit our documentation for detailed guides and information.
- Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.
Are #26583, #26586, and #26589 the same PR? Can two of these be closed?