hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-29191: Gracefully Handle Removed Configuration Properties in Hiv…

Open vikramahuja1001 opened this issue 4 months ago • 2 comments

…e 4 to Avoid Job Failures

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

vikramahuja1001 avatar Sep 11 '25 05:09 vikramahuja1001

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a new system session property “max_split_preload_per_driver” by declaring its constant, registering it with a default value, and exposing an accessor method.

Class diagram for updated SystemSessionProperties

classDiagram
    class SystemSessionProperties {
        +static final String MAX_SPLIT_PRELOAD_PER_DRIVER
        +static int getMaxSplitPreloadPerDriver(Session session)
    }
    SystemSessionProperties --> Session : uses
    class Session {
        +getSystemProperty(String, Class)
    }

File-Level Changes

Change Details Files
Introduce max_split_preload_per_driver system session property
  • Declare MAX_SPLIT_PRELOAD_PER_DRIVER constant
  • Register integerProperty with default 0 and description
  • Implement getMaxSplitPreloadPerDriver(Session) accessor
presto-main-base/src/main/java/com/facebook/presto/SystemSessionProperties.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it. You can also reply to a review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment @sourcery-ai summary on the pull request to (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

  • Contact our support team for questions or feedback.
  • Visit our documentation for detailed guides and information.
  • Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai[bot] avatar Nov 11 '25 19:11 sourcery-ai[bot]

Are #26583, #26586, and #26589 the same PR? Can two of these be closed?

steveburnett avatar Dec 09 '25 16:12 steveburnett