hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-28838: Remove sensitive jdbc properties from explain plan for JdbcStorageHandler tables

Open InvisibleProgrammer opened this issue 10 months ago • 3 comments

It removes the following sensitive properties from tables created with JdbcStorageHandler:

  • hive.sql.dbcp.username
  • hive.sql.dbcp.password

Why are the changes needed?

Explain extended can cause a security issue if they query sys tables: Sys tables are created with JdbcStorageHandler and so that, the output of explain extended will contain sensitive jdbc connection info.

Does this PR introduce any user-facing change?

Yes, it removes the listed properties from explain extended output when a JdbcStorageHandler table is included in a query.

Is the change a dependency upgrade?

No

How was this patch tested?

QTest added: explain_systest_password.q

InvisibleProgrammer avatar Mar 21 '25 11:03 InvisibleProgrammer

@zhangbutao , @zratkai , @deniskuzZ , thank you for the reviews so far. Do I have any question that I didn't answer or needs more to discuss about?

Thank you

InvisibleProgrammer avatar Apr 01 '25 08:04 InvisibleProgrammer