hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-28333: Skip CBO for UNIQUEJOIN and TABLESAMPLE

Open soumyakanti3578 opened this issue 1 year ago • 4 comments

What changes were proposed in this pull request?

Skip CBO for UNIQUEJOIN and TABLESAMPLE

Why are the changes needed?

Refer https://issues.apache.org/jira/browse/HIVE-27831

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

No

How was this patch tested?

By running various Ptests

soumyakanti3578 avatar Jun 17 '24 18:06 soumyakanti3578

Overall looks good to me, except the two comments, should we just create a separate PR for the union type, given its complexity, other things looks good to merge even now.

ramesh0201 avatar Aug 27 '24 14:08 ramesh0201

I will create a new PR for union type and address the comments there.

soumyakanti3578 avatar Aug 27 '24 16:08 soumyakanti3578

LGTM

ramesh0201 avatar Sep 06 '24 17:09 ramesh0201

Thank you @soumyakanti3578 for the patch.

ramesh0201 avatar Sep 06 '24 17:09 ramesh0201