hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-28240: Compaction requests remain in Working state after Timeout…

Open difin opened this issue 1 year ago • 3 comments

…Exception

What changes were proposed in this pull request?

When a compaction worker receive TimeoutException during execution of a compaction request, it attempts to cancel a running compaction by calling cancel on a compaction's Future object and by killing and recreating a compaction executor. However, we got a case on a downstream code where calling the cancel method on the compaction's future object didn't stop the compaction requests and they remained in the Working status. These changes propose marking compaction request as Failed to ensure that it doesn't stay in Working status.

Why are the changes needed?

To ensure that a compaction request doesn't stay in Working status after TimeoutException.

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

How was this patch tested?

Pre-commit tests.

difin avatar Apr 30 '24 17:04 difin

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Apr 30 '24 20:04 sonarqubecloud[bot]

Hi, could you please cover that with a test?

InvisibleProgrammer avatar May 09 '24 09:05 InvisibleProgrammer

sorry, I didn't notice the backoff and retry. we shouldn't just mark as aborted

deniskuzZ avatar May 26 '24 22:05 deniskuzZ

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Jul 26 '24 00:07 github-actions[bot]