hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-28164: Remove log4j transitive dependency

Open Aggarwal-Raghav opened this issue 1 year ago • 6 comments

What changes were proposed in this pull request?

There are dependency like accumulo and slf4j bringing log4j vulnerable jars in dependency tree. There are few dependencies also which don't appear in dependecy tree but are bringing old and vulnerable log4j. This can be observed in local m2 repo cache.

Why are the changes needed?

For CVE's and security reasons.

Does this PR introduce any user-facing change?

NO

Is the change a dependency upgrade?

Yes, here is new dependency tree: new-dependency-tree.txt

How was this patch tested?

Will see the UT from CI

Aggarwal-Raghav avatar Mar 29 '24 11:03 Aggarwal-Raghav

@zabetak, if you have bandwidth can you please review and provide your inputs on this?

Aggarwal-Raghav avatar Apr 02 '24 07:04 Aggarwal-Raghav

Apologies for the late response, Have updated the PR with suggested changes. I have created a new enforcer execution step to search for transitive dependencies of log4j. The scope of this PR is to only exclude log4j.

Aggarwal-Raghav avatar Apr 26 '24 11:04 Aggarwal-Raghav

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Apr 26 '24 16:04 sonarqubecloud[bot]

@zabetak , can you please help with review?

Aggarwal-Raghav avatar May 22 '24 15:05 Aggarwal-Raghav

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jun 18 '24 13:06 sonarqubecloud[bot]

@zabetak , can you please re-review it, if you have the bandwidth

Aggarwal-Raghav avatar Aug 04 '24 05:08 Aggarwal-Raghav

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Oct 04 '24 00:10 github-actions[bot]

I forgot about this issue. I will take a a look now.

zabetak avatar Oct 07 '24 07:10 zabetak

Thanks @zabetak , for the review. your insights are always appreciated. I will address the review comments :-)

Aggarwal-Raghav avatar Oct 08 '24 15:10 Aggarwal-Raghav

@zabetak, have updated the PR, can you please review?

Aggarwal-Raghav avatar Oct 15 '24 07:10 Aggarwal-Raghav