hive icon indicating copy to clipboard operation
hive copied to clipboard

Introduce gRPC Proto Definition

Open rohansonecha opened this issue 3 years ago • 1 comments

Change-Id: I38dd936e4ad710e05e95d78f05b5e07585cb1660

What changes were proposed in this pull request?

This pull request adds a new proto3 file which was based off of the existing hive_metastore.thrift file. The proto3 file is complete with all the requisite object and method header definitions to implement native gRPC support for Hive Metastore. This doesn’t include the same method with different signature, i.e. get_databases(string db_id) is usurped by get_databases(GetDatabasesRequest request).

The necessary dependencies were also added to the relevant pom.xml files to enable gRPC support.

Why are the changes needed?

The proto file is necessary because in order to have native gRPC support in Hive Metastore, there needs to be gRPC equivalents of all the preexisting Thrift objects as well as method header definitions in gRPC for Thrift counterparts.

Does this PR introduce any user-facing change?

Not yet, while this will allow developers to use this proto to generate clients (i.e. in Impala) before full support for gRPC is added in Hive Metastore.

How was this patch tested?

No tests were added in this PR other than making sure that the proto file and pom.xml files compile without issues and checking the target/ directory for generated files.

rohansonecha avatar Aug 18 '22 20:08 rohansonecha

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 25 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 23 '22 19:08 sonarqubecloud[bot]

hi @rohansonecha, thank you for submitting the PR. Is there an upstream JIRA to track this activity?

deniskuzZ avatar Oct 19 '22 14:10 deniskuzZ

Hello @deniskuzZ, yes there is. I have linked the JIRA ticket here: https://issues.apache.org/jira/browse/HIVE-26484.

rohansonecha avatar Oct 19 '22 15:10 rohansonecha

hi @rohansonecha, are you planning on contributing to Hive gRPC support? If yes, I can help with the reviews. This PR looks abandoned and would be marked as stale after a while.

deniskuzZ avatar Nov 15 '22 08:11 deniskuzZ