hive icon indicating copy to clipboard operation
hive copied to clipboard

HIVE-26436: Hive on MR NullPointerException When initializeOp has not…

Open ganlute opened this issue 3 years ago • 2 comments

… been called and close called.

What changes were proposed in this pull request?

When the operator has not been called to initialize, and it is called to close, exception will happen. I fix it by check conf is null so that the close could be finished. It work well in my cluster. However, I am not sure, it may be a better way to skip close if the operator has not been initialized ?

Why are the changes needed?

I think it may be a bug.

Does this PR introduce any user-facing change?

No

How was this patch tested?

  1. unit test passed.
  2. apply the patch to cluster and task passed.

ganlute avatar Jul 28 '22 15:07 ganlute

Can you add a unit test as well for this change

OK, I will update the unit test.

ganlute avatar Jul 30 '22 00:07 ganlute

hello @ayushtkn, thanks for your suggestion, I have add unit test to it. BTW, I found that not all the operator has the problem and it can happen at FileSinkOperator so I add it to the test case.

ganlute avatar Jul 30 '22 13:07 ganlute

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Oct 12 '22 00:10 github-actions[bot]