hive icon indicating copy to clipboard operation
hive copied to clipboard
verified publisher icon apache

HIVE-26196: Integrate Sonar analysis for the master branch and PRs

Open asolimando opened this issue 3 years ago • 6 comments

What changes were proposed in this pull request?

Adding Sonar analysis (no test coverage) for the master branch and PRs only at the moment, to track code quality metrics over time.

Why are the changes needed?

By running Sonar analysis regularly, we can catch critical bugs and issues more easily.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Sonar has been run locally and via CI (https://sonarcloud.io/summary/overall?id=apache_hive).

asolimando avatar Apr 28 '22 10:04 asolimando

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jun 01 '22 14:06 sonarqubecloud[bot]

@kgyrtkirk can you have another look? At the moment we are analyzing PRs and the master branch, I don't think we need to support labels or anything, because whatever change we want to make has to pass through a PR, we will spot eventual issues before merging, so I think we can stick with just analyzing the master branch (and not other branches, unless part of a PR). WDYT?

PS: I have updated the title of the Jira ticket, the message of the first commit is outdated, I am not amending it because otherwise it will trigger CI again for nothing.

asolimando avatar Jun 01 '22 16:06 asolimando

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.

github-actions[bot] avatar Aug 01 '22 00:08 github-actions[bot]

Dear bot, please keep the PR open!

asolimando avatar Aug 01 '22 08:08 asolimando

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug E 103 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 33 Security Hotspots
Code Smell A 1764 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 11 '22 08:08 sonarqubecloud[bot]

The test failures are due to flakyness and not related at all to the present PR, I am not going to run tests again to avoid wasting resources, I hope that's OK with you @zabetak

asolimando avatar Aug 11 '22 13:08 asolimando