HBASE-29735 Fix miscalculated timeoutInSeconds when using MoveWithAck

[jcongithub]

The PR tries to fix an issue in RegionMover when ack mode is enabled. It is related to HBASE-29734

Issues In RegionMover, timeoutInSeconds was calculated without considering retry attempts MoveWithAck. So waitMoveTasksToFinish may exit even though there are remaining retries in MoveWithAck.

Solution In RegionMover, use regions * wait_per_region * retries to calculate timeoutInSeconds

[Apache-HBase]

:broken_heart: -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 42s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 1s		codespell was not available.
+0 :ok:	detsecrets	0m 1s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
+1 :green_heart:	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 :green_heart:	mvninstall	6m 10s		master passed
+1 :green_heart:	compile	5m 40s		master passed
+1 :green_heart:	checkstyle	1m 49s		master passed
+1 :green_heart:	spotbugs	2m 49s		master passed
+1 :green_heart:	spotless	1m 28s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	4m 27s		the patch passed
+1 :green_heart:	compile	4m 13s		the patch passed
+1 :green_heart:	javac	4m 13s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	1m 25s		the patch passed
+1 :green_heart:	spotbugs	2m 51s		the patch passed
+1 :green_heart:	hadoopcheck	20m 33s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
-1 :x:	spotless	1m 19s		patch has 44 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 :green_heart:	asflicense	0m 20s		The patch does not generate ASF License warnings.
		66m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/7519
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux f91fb4275101 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 6fb7d1e885ad09ba500b6219ec4e3dd97eb59525
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	134 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 47s		Docker mode activated.
-0 :warning:	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 :green_heart:	mvninstall	5m 39s		master passed
+1 :green_heart:	compile	1m 47s		master passed
+1 :green_heart:	javadoc	0m 51s		master passed
+1 :green_heart:	shadedjars	9m 16s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	5m 6s		the patch passed
+1 :green_heart:	compile	1m 39s		the patch passed
+1 :green_heart:	javac	1m 39s		the patch passed
+1 :green_heart:	javadoc	0m 49s		the patch passed
+1 :green_heart:	shadedjars	8m 25s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 :green_heart:	unit	227m 48s		hbase-server in the patch passed.
		266m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/7519
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 471442366cf7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 6fb7d1e885ad09ba500b6219ec4e3dd97eb59525
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/1/testReport/
Max. process+thread count	4086 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 41s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
+1 :green_heart:	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 :green_heart:	mvninstall	4m 53s		master passed
+1 :green_heart:	compile	4m 41s		master passed
+1 :green_heart:	checkstyle	1m 21s		master passed
+1 :green_heart:	spotbugs	2m 15s		master passed
+1 :green_heart:	spotless	1m 5s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	4m 1s		the patch passed
+1 :green_heart:	compile	4m 9s		the patch passed
+1 :green_heart:	javac	4m 9s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	1m 13s		the patch passed
+1 :green_heart:	spotbugs	2m 7s		the patch passed
+1 :green_heart:	hadoopcheck	17m 46s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 :green_heart:	spotless	1m 11s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 :green_heart:	asflicense	0m 17s		The patch does not generate ASF License warnings.
		58m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/7519
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux cb841a9f99c4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 5bd7327c293c54d2761d85efb3b4e242803d38af
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	142 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:broken_heart: -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	2m 2s		Docker mode activated.
-0 :warning:	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 :green_heart:	mvninstall	5m 7s		master passed
+1 :green_heart:	compile	1m 16s		master passed
+1 :green_heart:	javadoc	0m 41s		master passed
+1 :green_heart:	shadedjars	7m 1s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	4m 42s		the patch passed
+1 :green_heart:	compile	1m 19s		the patch passed
+1 :green_heart:	javac	1m 19s		the patch passed
+1 :green_heart:	javadoc	0m 38s		the patch passed
+1 :green_heart:	shadedjars	6m 57s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 :x:	unit	474m 48s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		509m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/7519
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux b251b05247aa 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 5bd7327c293c54d2761d85efb3b4e242803d38af
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/2/testReport/
Max. process+thread count	2724 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:broken_heart: -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 0s		Docker mode activated.
-1 :x:	docker	0m 2s		Docker failed to build run-specific yetus/hbase:tp-22047}.

Subsystem	Report/Notes
GITHUB PR	https://github.com/apache/hbase/pull/7519
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/3/console
versions	git=2.17.1
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:broken_heart: -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 30s		Docker mode activated.
-0 :warning:	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 :green_heart:	mvninstall	3m 52s		master passed
+1 :green_heart:	compile	1m 3s		master passed
+1 :green_heart:	javadoc	0m 32s		master passed
+1 :green_heart:	shadedjars	6m 15s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	3m 20s		the patch passed
+1 :green_heart:	compile	1m 3s		the patch passed
+1 :green_heart:	javac	1m 3s		the patch passed
+1 :green_heart:	javadoc	0m 30s		the patch passed
+1 :green_heart:	shadedjars	6m 9s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 :x:	unit	210m 20s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		237m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/7519
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 530f11c32eb8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 30a50d2dbbbca131928f1c66b42ecc63988453c8
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/3/testReport/
Max. process+thread count	4237 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[PDavid]

Hi @jcongithub,

Thanks for your contribution. Can you please add the Jira ticket ID to the commit message - e.g. use the commit message format documented here: https://hbase.apache.org/book.html#hbase.commit.msg.format

Please also update the PR title to start with the Jira ticket ID.

[jcongithub]

Thanks @PDavid

Updated

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 32s		Docker mode activated.
			_ Prechecks _
+1 :green_heart:	dupname	0m 0s		No case conflicting files found.
+0 :ok:	codespell	0m 0s		codespell was not available.
+0 :ok:	detsecrets	0m 0s		detect-secrets was not available.
+1 :green_heart:	@author	0m 0s		The patch does not contain any @author tags.
+1 :green_heart:	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 :green_heart:	mvninstall	4m 27s		master passed
+1 :green_heart:	compile	3m 46s		master passed
+1 :green_heart:	checkstyle	1m 11s		master passed
+1 :green_heart:	spotbugs	1m 52s		master passed
+1 :green_heart:	spotless	1m 0s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	3m 44s		the patch passed
+1 :green_heart:	compile	3m 59s		the patch passed
+1 :green_heart:	javac	3m 59s		the patch passed
+1 :green_heart:	blanks	0m 0s		The patch has no blanks issues.
+1 :green_heart:	checkstyle	1m 16s		the patch passed
+1 :green_heart:	spotbugs	2m 14s		the patch passed
+1 :green_heart:	hadoopcheck	14m 36s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 :green_heart:	spotless	0m 55s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 :green_heart:	asflicense	0m 12s		The patch does not generate ASF License warnings.
		48m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/7519
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 9a19caf5c512 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / ae470c1974d0db30f545dd1b35b75bb2b950fad4
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/4/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

:confetti_ball: +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 :ok:	reexec	0m 41s		Docker mode activated.
-0 :warning:	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 :green_heart:	mvninstall	5m 0s		master passed
+1 :green_heart:	compile	1m 10s		master passed
+1 :green_heart:	javadoc	0m 41s		master passed
+1 :green_heart:	shadedjars	6m 59s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 :green_heart:	mvninstall	4m 17s		the patch passed
+1 :green_heart:	compile	1m 12s		the patch passed
+1 :green_heart:	javac	1m 12s		the patch passed
+1 :green_heart:	javadoc	0m 43s		the patch passed
+1 :green_heart:	shadedjars	6m 59s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 :green_heart:	unit	219m 36s		hbase-server in the patch passed.
		251m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	https://github.com/apache/hbase/pull/7519
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux c2cfabd5acee 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / ae470c1974d0db30f545dd1b35b75bb2b950fad4
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/4/testReport/
Max. process+thread count	4638 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7519/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[guluo2016]

Is it possible to add a unit test for this?