HBASE-28988 Enhance WALPlayer for restore of BulkLoad
Enhance WALPlayer for restore of BulkLoad WAL entries
https://issues.apache.org/jira/browse/HBASE-28988
Need to update for newly suggested backup directory structure
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 0s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 0s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | |
| _ HBASE-28957 Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | |
| +1 :green_heart: | mvninstall | 3m 8s | HBASE-28957 passed | |
| +1 :green_heart: | compile | 1m 4s | HBASE-28957 passed | |
| +1 :green_heart: | checkstyle | 0m 20s | HBASE-28957 passed | |
| +1 :green_heart: | spotbugs | 0m 54s | HBASE-28957 passed | |
| +1 :green_heart: | spotless | 0m 45s | branch has no errors when running spotless:check. | |
| _ Patch Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | |
| +1 :green_heart: | mvninstall | 2m 59s | the patch passed | |
| +1 :green_heart: | compile | 1m 4s | the patch passed | |
| -0 :warning: | javac | 0m 34s | /results-compile-javac-hbase-mapreduce.txt | hbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198) |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| -0 :warning: | checkstyle | 0m 10s | /results-checkstyle-hbase-mapreduce.txt | hbase-mapreduce: The patch generated 13 new + 1 unchanged - 0 fixed = 14 total (was 1) |
| -0 :warning: | checkstyle | 0m 9s | /results-checkstyle-hbase-it.txt | hbase-it: The patch generated 2 new + 20 unchanged - 0 fixed = 22 total (was 20) |
| +1 :green_heart: | spotbugs | 1m 9s | the patch passed | |
| +1 :green_heart: | hadoopcheck | 11m 25s | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. | |
| -1 :x: | spotless | 0m 38s | patch has 65 errors when running spotless:check, run spotless:apply to fix. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. | |
| 32m 15s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6523 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux b3087804891f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-28957 / ff90ac91ffe9554802d98d53351a4deda5c655bb |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/1/artifact/yetus-general-check/output/patch-spotless.txt |
| Max. process+thread count | 83 (vs. ulimit of 30000) |
| modules | C: hbase-mapreduce hbase-it U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/1/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. | |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck | |
| _ Prechecks _ | ||||
| _ HBASE-28957 Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | |
| +1 :green_heart: | mvninstall | 3m 47s | HBASE-28957 passed | |
| +1 :green_heart: | compile | 0m 50s | HBASE-28957 passed | |
| +1 :green_heart: | javadoc | 0m 37s | HBASE-28957 passed | |
| +1 :green_heart: | shadedjars | 6m 16s | branch has no errors when building our shaded downstream artifacts. | |
| _ Patch Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | |
| +1 :green_heart: | mvninstall | 3m 0s | the patch passed | |
| +1 :green_heart: | compile | 0m 40s | the patch passed | |
| +1 :green_heart: | javac | 0m 40s | the patch passed | |
| +1 :green_heart: | javadoc | 0m 26s | the patch passed | |
| +1 :green_heart: | shadedjars | 5m 43s | patch has no errors when building our shaded downstream artifacts. | |
| _ Other Tests _ | ||||
| -1 :x: | unit | 27m 48s | /patch-unit-hbase-mapreduce.txt | hbase-mapreduce in the patch failed. |
| +1 :green_heart: | unit | 1m 1s | hbase-it in the patch passed. | |
| 52m 19s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6523 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 1e184da7deae 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-28957 / ff90ac91ffe9554802d98d53351a4deda5c655bb |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/1/testReport/ |
| Max. process+thread count | 3361 (vs. ulimit of 30000) |
| modules | C: hbase-mapreduce hbase-it U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
@ankitsol You need to run mvn spotless:apply to fix code style issues.
:confetti_ball: +1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 40s | Docker mode activated. | |
| _ Prechecks _ | ||||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | |
| +0 :ok: | codespell | 0m 0s | codespell was not available. | |
| +0 :ok: | detsecrets | 0m 0s | detect-secrets was not available. | |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | |
| _ HBASE-28957 Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch | |
| +1 :green_heart: | mvninstall | 2m 46s | HBASE-28957 passed | |
| +1 :green_heart: | compile | 1m 6s | HBASE-28957 passed | |
| +1 :green_heart: | checkstyle | 0m 23s | HBASE-28957 passed | |
| +1 :green_heart: | spotbugs | 0m 59s | HBASE-28957 passed | |
| +1 :green_heart: | spotless | 1m 7s | branch has no errors when running spotless:check. | |
| _ Patch Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | |
| +1 :green_heart: | mvninstall | 3m 0s | the patch passed | |
| +1 :green_heart: | compile | 1m 4s | the patch passed | |
| -0 :warning: | javac | 0m 33s | /results-compile-javac-hbase-mapreduce.txt | hbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198) |
| +1 :green_heart: | blanks | 0m 0s | The patch has no blanks issues. | |
| +1 :green_heart: | checkstyle | 0m 24s | the patch passed | |
| +1 :green_heart: | spotbugs | 1m 6s | the patch passed | |
| +1 :green_heart: | hadoopcheck | 9m 55s | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. | |
| +1 :green_heart: | spotless | 0m 39s | patch has no errors when running spotless:check. | |
| _ Other Tests _ | ||||
| +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. | |
| 30m 9s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6523 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 68382c610f0a 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-28957 / 12fdd6dbdcfea1ce8b0721ea708212fc0079d5b6 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 83 (vs. ulimit of 30000) |
| modules | C: hbase-mapreduce hbase-it U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/2/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Logfile | Comment |
|---|---|---|---|---|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. | |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck | |
| _ Prechecks _ | ||||
| _ HBASE-28957 Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | |
| +1 :green_heart: | mvninstall | 3m 34s | HBASE-28957 passed | |
| +1 :green_heart: | compile | 0m 49s | HBASE-28957 passed | |
| +1 :green_heart: | javadoc | 0m 31s | HBASE-28957 passed | |
| +1 :green_heart: | shadedjars | 7m 27s | branch has no errors when building our shaded downstream artifacts. | |
| _ Patch Compile Tests _ | ||||
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | |
| +1 :green_heart: | mvninstall | 4m 7s | the patch passed | |
| +1 :green_heart: | compile | 0m 42s | the patch passed | |
| +1 :green_heart: | javac | 0m 42s | the patch passed | |
| +1 :green_heart: | javadoc | 0m 25s | the patch passed | |
| +1 :green_heart: | shadedjars | 5m 37s | patch has no errors when building our shaded downstream artifacts. | |
| _ Other Tests _ | ||||
| -1 :x: | unit | 27m 20s | /patch-unit-hbase-mapreduce.txt | hbase-mapreduce in the patch failed. |
| +1 :green_heart: | unit | 0m 39s | hbase-it in the patch passed. | |
| 53m 33s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6523 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux b92f4b8e2b6c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-28957 / 12fdd6dbdcfea1ce8b0721ea708212fc0079d5b6 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/2/testReport/ |
| Max. process+thread count | 3286 (vs. ulimit of 30000) |
| modules | C: hbase-mapreduce hbase-it U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6523/2/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
As discussed internally we need to add this enhancement outside of the WALPlayer class. Perhaps we could try to extend WALPlayer and the mapper to create a new MR job with the two functionalities mixed together.
One thing I don't understand reading this patch: how the original code skipped BulkLoad edits and how the new code enabled them?