hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

HADOOP-19564: delete configuration io.compression.codec.lzo.buffersize in core-default.xml

Open zeekling opened this issue 8 months ago • 2 comments

Description of PR

PR for HADOOP-19564

How was this patch tested?

For code changes:

  • [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

zeekling avatar May 25 '25 15:05 zeekling

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 14m 23s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: xmllint 0m 0s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 35m 33s trunk passed
+1 :green_heart: compile 15m 53s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 13m 52s trunk passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: mvnsite 1m 40s trunk passed
+1 :green_heart: javadoc 1m 18s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 0m 56s trunk passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: shadedclient 104m 43s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 55s the patch passed
+1 :green_heart: compile 15m 6s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 15m 6s the patch passed
+1 :green_heart: compile 13m 57s the patch passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: javac 13m 57s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: mvnsite 1m 39s the patch passed
+1 :green_heart: javadoc 1m 12s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 0m 55s the patch passed with JDK Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
+1 :green_heart: shadedclient 40m 43s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 15m 24s hadoop-common in the patch passed.
+1 :green_heart: asflicense 1m 6s The patch does not generate ASF License warnings.
208m 29s
Subsystem Report/Notes
Docker ClientAPI=1.49 ServerAPI=1.49 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7708/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/7708
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux 58d7d0dff95a 5.15.0-136-generic #147-Ubuntu SMP Sat Mar 15 15:53:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 450e163c5ed90e493a085e4815296f7311f7e321
Default Java Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~us1-0ubuntu1~20.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7708/1/testReport/
Max. process+thread count 3001 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7708/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar May 25 '25 18:05 hadoop-yetus

It is common for downstream projects to provide different default values ​​for certain configuration items when using a library. If you think the current default value should be changed, please provide benchmarks to support your idea.

The lzo's code is in a separate repository. I don't think we should maintain default values ​​related to lzo. It should be in hadoop-lzo repository not in hadoop.

zeekling avatar Jun 17 '25 15:06 zeekling

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again. Thanks all for your contribution.

github-actions[bot] avatar Sep 26 '25 00:09 github-actions[bot]