hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

HDFS-17559. Fix the uuid as null in NameNodeMXBean

Open haiyang1987 opened this issue 1 year ago • 4 comments

Description of PR

https://issues.apache.org/jira/browse/HDFS-17559

If there is datanode info in includes, but the datanode service is not currently started, the uuid of the datanode will be null. when get the DeadNodes DeadNodes metric, the following exception will occur:


2024-06-26 17:06:49,698 ERROR jmx.JMXJsonServlet (JMXJsonServlet.java:writeAttribute(345)) [qtp1107412069-7704] - getting attribute DeadNodes of Hadoop:service=NameNode,name=NameNodeInfo threw an exception javax.management.RuntimeMBeanException: java.lang.NullPointerException: null value in entry: uuid=null
        at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrow(DefaultMBeanServerInterceptor.java:839)
        at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrowMaybeMBeanException(DefaultMBeanServerInterceptor.java:852)
        at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:651)
        at com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:678)
        at org.apache.hadoop.jmx.JMXJsonServlet.writeAttribute(JMXJsonServlet.java:338)

haiyang1987 avatar Jun 27 '24 10:06 haiyang1987

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 47s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 14m 18s Maven dependency ordering for branch
+1 :green_heart: mvninstall 36m 26s trunk passed
+1 :green_heart: compile 6m 5s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: compile 5m 47s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: checkstyle 1m 29s trunk passed
+1 :green_heart: mvnsite 2m 17s trunk passed
+1 :green_heart: javadoc 1m 51s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: javadoc 2m 25s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: spotbugs 5m 50s trunk passed
+1 :green_heart: shadedclient 41m 7s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 31s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 0s the patch passed
+1 :green_heart: compile 5m 58s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: javac 5m 58s the patch passed
+1 :green_heart: compile 5m 45s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: javac 5m 45s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
-0 :warning: checkstyle 1m 18s /results-checkstyle-hadoop-hdfs-project.txt hadoop-hdfs-project: The patch generated 2 new + 126 unchanged - 0 fixed = 128 total (was 126)
+1 :green_heart: mvnsite 2m 4s the patch passed
+1 :green_heart: javadoc 1m 31s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: javadoc 2m 9s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: spotbugs 6m 0s the patch passed
+1 :green_heart: shadedclient 41m 5s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 22s hadoop-hdfs-client in the patch passed.
-1 :x: unit 255m 30s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 :green_heart: asflicense 0m 44s The patch does not generate ASF License warnings.
443m 41s
Reason Tests
Failed junit tests hadoop.hdfs.server.blockmanagement.TestDatanodeManager
hadoop.hdfs.TestRollingUpgrade
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6906/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6906
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 47eac06f33a9 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / cf882563e3c5233fb08d4741ec29fd4e4a37cd93
Default Java Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6906/1/testReport/
Max. process+thread count 2844 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6906/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Jun 27 '24 18:06 hadoop-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 48s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 14m 23s Maven dependency ordering for branch
+1 :green_heart: mvninstall 36m 56s trunk passed
+1 :green_heart: compile 6m 4s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: compile 5m 51s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: checkstyle 1m 30s trunk passed
+1 :green_heart: mvnsite 2m 20s trunk passed
+1 :green_heart: javadoc 1m 51s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: javadoc 2m 25s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: spotbugs 5m 52s trunk passed
+1 :green_heart: shadedclient 41m 6s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 31s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 1s the patch passed
+1 :green_heart: compile 5m 58s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: javac 5m 58s the patch passed
+1 :green_heart: compile 5m 43s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: javac 5m 43s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 18s the patch passed
+1 :green_heart: mvnsite 2m 3s the patch passed
+1 :green_heart: javadoc 1m 33s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: javadoc 2m 5s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: spotbugs 6m 2s the patch passed
+1 :green_heart: shadedclient 41m 13s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 22s hadoop-hdfs-client in the patch passed.
-1 :x: unit 258m 6s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 :green_heart: asflicense 0m 44s The patch does not generate ASF License warnings.
447m 0s
Reason Tests
Failed junit tests hadoop.hdfs.server.blockmanagement.TestDatanodeManager
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6906/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6906
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux d03ca785d5d6 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 5091f8a264f9531148ca31fcceb99eff8b4a2b97
Default Java Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6906/2/testReport/
Max. process+thread count 2845 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6906/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Jun 28 '24 09:06 hadoop-yetus

The failed unit test seems unrelated to the change.

haiyang1987 avatar Jun 28 '24 14:06 haiyang1987

Hi @Hexiaoqiao @ZanderXu @zhangshuyan0 could you please help me review this pr when you have free time? Thanks~.

haiyang1987 avatar Jul 01 '24 11:07 haiyang1987

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 14m 8s Maven dependency ordering for branch
+1 :green_heart: mvninstall 37m 45s trunk passed
+1 :green_heart: compile 6m 4s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: compile 5m 42s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: checkstyle 1m 28s trunk passed
+1 :green_heart: mvnsite 2m 20s trunk passed
+1 :green_heart: javadoc 1m 51s trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: javadoc 2m 20s trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: spotbugs 5m 52s trunk passed
+1 :green_heart: shadedclient 41m 15s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 32s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 59s the patch passed
+1 :green_heart: compile 5m 55s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: javac 5m 55s the patch passed
+1 :green_heart: compile 5m 41s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: javac 5m 41s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 20s the patch passed
+1 :green_heart: mvnsite 2m 4s the patch passed
+1 :green_heart: javadoc 1m 32s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 :green_heart: javadoc 2m 8s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 :green_heart: spotbugs 5m 59s the patch passed
+1 :green_heart: shadedclient 41m 3s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 2m 21s hadoop-hdfs-client in the patch passed.
-1 :x: unit 250m 59s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 :green_heart: asflicense 0m 43s The patch does not generate ASF License warnings.
440m 11s
Reason Tests
Failed junit tests hadoop.hdfs.server.blockmanagement.TestDatanodeManager
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6906/3/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6906
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux c386d44e5d36 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 9974189a6f0154a3bf2d9c3f48131ea004793357
Default Java Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6906/3/testReport/
Max. process+thread count 3048 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6906/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Jul 05 '24 14:07 hadoop-yetus

Thanks for @ayushtkn review and merge.

haiyang1987 avatar Jul 06 '24 08:07 haiyang1987