hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

YARN-11686. Correct traversing indexs when scheduling asynchronously using Capacity Scheduler

Open onebox-li opened this issue 1 year ago • 4 comments

Description of PR

When scheduling asynchronously using Capacity Scheduler, the traversing indexs in CapacityScheduler#schedule will always contains start index twice. This may not in line with the original intention and needs to be corrected.

How was this patch tested?

Manual test. This is a minor logic change, so I think there's no need to add new tests. I add debug log to print node when actually traversing nodes. And before this patch,it always contains start node twice. After this patch, it looks good.

For code changes:

  • [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

onebox-li avatar Apr 18 '24 04:04 onebox-li

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 20s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 1s codespell was not available.
+0 :ok: detsecrets 0m 1s detect-secrets was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 32m 44s trunk passed
+1 :green_heart: compile 0m 35s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: compile 0m 32s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: checkstyle 0m 33s trunk passed
+1 :green_heart: mvnsite 0m 39s trunk passed
+1 :green_heart: javadoc 0m 37s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: javadoc 0m 31s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: spotbugs 1m 13s trunk passed
+1 :green_heart: shadedclient 20m 40s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 26s the patch passed
+1 :green_heart: compile 0m 30s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: javac 0m 30s the patch passed
+1 :green_heart: compile 0m 29s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: javac 0m 29s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 0m 23s the patch passed
+1 :green_heart: mvnsite 0m 26s the patch passed
+1 :green_heart: javadoc 0m 26s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 :green_heart: javadoc 0m 28s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 :green_heart: spotbugs 1m 6s the patch passed
+1 :green_heart: shadedclient 20m 27s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 89m 17s hadoop-yarn-server-resourcemanager in the patch passed.
+1 :green_heart: asflicense 0m 25s The patch does not generate ASF License warnings.
175m 6s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6750/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6750
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 37548fb3f02c 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 0e1ae3a46317d9941462ffc5f2aaf3271d0b3390
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6750/1/testReport/
Max. process+thread count 961 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6750/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Apr 18 '24 07:04 hadoop-yetus

Gentle ping @slfan1989 @zhuqi-lucas @brumi1024. PTAL if you have time, thanks! It' s ready for review.

onebox-li avatar Apr 22 '24 09:04 onebox-li

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 :green_heart: dupname 0m 00s No case conflicting files found.
+0 :ok: spotbugs 0m 01s spotbugs executables are not available.
+0 :ok: codespell 0m 01s codespell was not available.
+0 :ok: detsecrets 0m 01s detect-secrets was not available.
+1 :green_heart: @author 0m 00s The patch does not contain any @author tags.
-1 :x: test4tests 0m 00s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 89m 08s trunk passed
+1 :green_heart: compile 6m 00s trunk passed
+1 :green_heart: checkstyle 4m 44s trunk passed
+1 :green_heart: mvnsite 5m 51s trunk passed
+1 :green_heart: javadoc 5m 28s trunk passed
+1 :green_heart: shadedclient 147m 10s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 36s the patch passed
+1 :green_heart: compile 3m 11s the patch passed
+1 :green_heart: javac 3m 11s the patch passed
+1 :green_heart: blanks 0m 01s The patch has no blanks issues.
+1 :green_heart: checkstyle 2m 15s the patch passed
+1 :green_heart: mvnsite 3m 20s the patch passed
+1 :green_heart: javadoc 3m 02s the patch passed
+1 :green_heart: shadedclient 158m 41s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: asflicense 5m 33s The patch does not generate ASF License warnings.
420m 52s
Subsystem Report/Notes
GITHUB PR https://github.com/apache/hadoop/pull/6750
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname MINGW64_NT-10.0-17763 e0c4ad74b72d 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / 0e1ae3a46317d9941462ffc5f2aaf3271d0b3390
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6750/1/testReport/
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6750/1/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Apr 23 '24 08:04 hadoop-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 :green_heart: dupname 0m 01s No case conflicting files found.
+0 :ok: spotbugs 0m 00s spotbugs executables are not available.
+0 :ok: codespell 0m 00s codespell was not available.
+0 :ok: detsecrets 0m 00s detect-secrets was not available.
+1 :green_heart: @author 0m 01s The patch does not contain any @author tags.
-1 :x: test4tests 0m 01s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 :green_heart: mvninstall 91m 20s trunk passed
+1 :green_heart: compile 6m 22s trunk passed
+1 :green_heart: checkstyle 4m 47s trunk passed
+1 :green_heart: mvnsite 6m 04s trunk passed
+1 :green_heart: javadoc 5m 39s trunk passed
+1 :green_heart: shadedclient 154m 19s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 3m 39s the patch passed
+1 :green_heart: compile 3m 13s the patch passed
+1 :green_heart: javac 3m 13s the patch passed
+1 :green_heart: blanks 0m 01s The patch has no blanks issues.
+1 :green_heart: checkstyle 2m 14s the patch passed
+1 :green_heart: mvnsite 3m 21s the patch passed
+1 :green_heart: javadoc 3m 00s the patch passed
+1 :green_heart: shadedclient 159m 43s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: asflicense 5m 22s The patch does not generate ASF License warnings.
431m 33s
Subsystem Report/Notes
GITHUB PR https://github.com/apache/hadoop/pull/6750
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname MINGW64_NT-10.0-17763 7a39ef331537 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / 0e1ae3a46317d9941462ffc5f2aaf3271d0b3390
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6750/2/testReport/
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6750/2/console
versions git=2.44.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Apr 29 '24 05:04 hadoop-yetus

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again. Thanks all for your contribution.

github-actions[bot] avatar Sep 28 '25 00:09 github-actions[bot]