hadoop icon indicating copy to clipboard operation
hadoop copied to clipboard

HDFS-17300. [SBN READ] A rpc call in Observer should throw ObserverRetryOnActiveException if its stateid is always lower than client stateid for a configured time.

Open LiuGuH opened this issue 2 years ago • 5 comments

…ateid is always delayed with Active Namenode for a period of time

Description of PR

JIRA: HDFS-17300

Now when Observer is enable, Observer will update its stateid through that EditLogTailer near-real-time tailing editlog form Active Namenode. And if a rpc call's stateid is lower than client stateid which may update from active namenode with msync, the call will be requeued into callqueue.

This PR is intend to if a rpc call's stateid is always lower than client statid for a configured time , the call should throw ObserverRetryOnActiveException for client and client will go to active namenode for processing.

LiuGuH avatar Jan 05 '24 10:01 LiuGuH

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 21s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: xmllint 0m 0s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 14m 2s Maven dependency ordering for branch
+1 :green_heart: mvninstall 20m 14s trunk passed
+1 :green_heart: compile 8m 40s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 7m 45s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: checkstyle 2m 3s trunk passed
+1 :green_heart: mvnsite 1m 40s trunk passed
+1 :green_heart: javadoc 1m 18s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 33s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
-1 :x: spotbugs 1m 45s /branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant spotbugs warnings.
+1 :green_heart: shadedclient 21m 1s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 19s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 4s the patch passed
+1 :green_heart: compile 8m 9s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 8m 9s the patch passed
+1 :green_heart: compile 7m 37s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: javac 7m 37s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 2m 2s the patch passed
+1 :green_heart: mvnsite 1m 44s the patch passed
+1 :green_heart: javadoc 1m 14s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 43s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: spotbugs 3m 22s the patch passed
+1 :green_heart: shadedclient 21m 31s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 :x: unit 15m 58s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch passed.
-1 :x: unit 186m 47s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 :green_heart: asflicense 0m 41s The patch does not generate ASF License warnings.
335m 31s
Reason Tests
Failed junit tests hadoop.conf.TestCommonConfigurationFields
hadoop.hdfs.server.datanode.TestDirectoryScanner
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6414/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6414
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux 388e1a351c90 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c589b62974209b5fbf08716838757f56b9882dda
Default Java Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6414/1/testReport/
Max. process+thread count 4145 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6414/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Jan 05 '24 16:01 hadoop-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 6m 54s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: xmllint 0m 0s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 14m 11s Maven dependency ordering for branch
+1 :green_heart: mvninstall 20m 29s trunk passed
+1 :green_heart: compile 8m 34s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 7m 45s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: checkstyle 2m 1s trunk passed
+1 :green_heart: mvnsite 1m 38s trunk passed
+1 :green_heart: javadoc 1m 18s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 32s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: spotbugs 3m 8s trunk passed
+1 :green_heart: shadedclient 21m 42s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 22s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 7s the patch passed
+1 :green_heart: compile 8m 15s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 8m 15s the patch passed
+1 :green_heart: compile 7m 50s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: javac 7m 50s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 58s the patch passed
+1 :green_heart: mvnsite 1m 37s the patch passed
+1 :green_heart: javadoc 1m 11s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 31s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: spotbugs 3m 18s the patch passed
+1 :green_heart: shadedclient 21m 42s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 15m 40s hadoop-common in the patch passed.
-1 :x: unit 191m 22s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 :green_heart: asflicense 0m 38s The patch does not generate ASF License warnings.
347m 4s
Reason Tests
Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
hadoop.hdfs.TestErasureCodingPolicies
hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
hadoop.hdfs.TestDistributedFileSystemWithECFileWithRandomECPolicy
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6414/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6414
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux 5eea4a21e82e 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 56101db610b19013c3a1fa57a61afb7845cd3971
Default Java Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6414/2/testReport/
Max. process+thread count 3824 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6414/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Jan 10 '24 09:01 hadoop-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Logfile Comment
+0 :ok: reexec 0m 21s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+0 :ok: codespell 0m 0s codespell was not available.
+0 :ok: detsecrets 0m 0s detect-secrets was not available.
+0 :ok: xmllint 0m 0s xmllint was not available.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 :ok: mvndep 13m 59s Maven dependency ordering for branch
+1 :green_heart: mvninstall 19m 48s trunk passed
+1 :green_heart: compile 8m 32s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 7m 55s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: checkstyle 2m 5s trunk passed
+1 :green_heart: mvnsite 1m 40s trunk passed
+1 :green_heart: javadoc 1m 20s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 35s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: spotbugs 3m 12s trunk passed
+1 :green_heart: shadedclient 21m 37s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 21s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 8s the patch passed
+1 :green_heart: compile 7m 58s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 7m 58s the patch passed
+1 :green_heart: compile 7m 39s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: javac 7m 39s the patch passed
+1 :green_heart: blanks 0m 0s The patch has no blanks issues.
+1 :green_heart: checkstyle 1m 57s the patch passed
+1 :green_heart: mvnsite 1m 41s the patch passed
+1 :green_heart: javadoc 1m 21s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 41s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 :green_heart: spotbugs 3m 16s the patch passed
+1 :green_heart: shadedclient 20m 37s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 :green_heart: unit 15m 45s hadoop-common in the patch passed.
+1 :green_heart: unit 187m 18s hadoop-hdfs in the patch passed.
+1 :green_heart: asflicense 0m 44s The patch does not generate ASF License warnings.
335m 12s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6414/3/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/hadoop/pull/6414
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname Linux 944f1f3dd85f 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 3253b3ba230da6b7d9ffadefcd83dfc3506275b6
Default Java Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6414/3/testReport/
Max. process+thread count 3836 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6414/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus avatar Jan 10 '24 15:01 hadoop-yetus

@chliang71 Do you have time to review this? Thanks

LiuGuH avatar Jan 11 '24 07:01 LiuGuH

@Hexiaoqiao ,hello ,sir. Do you have time to review this, Thanks!

LiuGuH avatar Jan 23 '24 12:01 LiuGuH