apache
GUACAMOLE-288: Add support for multi-monitor connections.
Allows as is to add multiple monitors of the same dimensions in RDP protocol if the server supports it. I haven't looked at the VNC part yet.
Client side PR : https://github.com/apache/guacamole-client/pull/1061
POC:
it will be great if we bring that to main
Yes, that is the plan, once the code is finalized and has been fully reviewed.
Frequently resizing a monitor window, e.g. by using Maximize and Restore down of the window in quick succession, can cause a RDP disconnect with the following message in the guacd logs:
GUAC_ASSERT in guac_rdp_gdi_desktop_resize() failed at gdi.c:172.
Is it possible to wait for the flush or just discard the affected window instead of crashing the connection?
Frequently resizing a monitor window, e.g. by using Maximize and Restore down of the window in quick succession, can cause a RDP disconnect with the following message in the guacd logs:
GUAC_ASSERT in guac_rdp_gdi_desktop_resize() failed at gdi.c:172.Is it possible to wait for the flush or just discard the affected window instead of crashing the connection?
Which version of freerdp are you using? If you are on v3, can you update it to at least version 3.8.0?
I'm using the Dockerfile from the repository which defaults to FreeRDP 2. The exact version is 2.11.7. I can try using FreeRDP 3 to see if that improves anything.
I'm using the Dockerfile form the repository which defaults to FreeRDP 2. The exact version is
2.11.7. I can try using FreeRDP 3 to see if that improves anything.
This is potentially a bug in FreeRDP. This assertion is mandatory in version 2. Are you sure you can't reproduce this with a single monitor?
I don't think I tried it with one monitor. Will do that as well once I have the time.
I'm using the Dockerfile form the repository which defaults to FreeRDP 2. The exact version is
2.11.7. I can try using FreeRDP 3 to see if that improves anything.This is potentially a bug in FreeRDP. This assertion is mandatory in version 2. Are you sure you can't reproduce this with a single monitor?
I was able to reproduce it with one monitor with the FreeRDP 2 build.
EDIT: It does not reproduce with FreeRDP 3, independent of the number of monitors.
@necouchman @corentin-soriano Thanks for adding this feature! Do you plan to merge it into the main branch?
@necouchman @corentin-soriano Thanks for adding this feature! Do you plan to merge it into the main branch?
I still have some things to finalize before we can merge. I haven't had time to continue lately but the subject has not been forgotten!