guacamole-server icon indicating copy to clipboard operation
guacamole-server copied to clipboard
verified publisher icon apache

GUACAMOLE-1447: bump docker base image to Debian Bullseye

Open xens opened this issue 4 years ago • 6 comments

Bumping Docker base image to Debian latest stable Debian Bullseye.

  • https://issues.apache.org/jira/browse/GUACAMOLE-1447
  • https://www.debian.org/releases/

What I tested on Guacamole version 1.3.0:

:heavy_check_mark: Connection to a RDP host :heavy_check_mark: Connection to a SSH target + verifying the remote-server key (known host key) :heavy_check_mark: Connection to a SSH target with user/pass authentication :heavy_check_mark: Connection to a SSH target with pubkey authentication (with an un-encrypted private key) :heavy_check_mark: Connection to a SSH target with pubkey authentication (with an un-encrypted private key)

xens avatar Oct 18 '21 11:10 xens

@xens I'm good with this, assuming @mike-jumper doesn't have any concerns. A couple of questions for you, though:

  1. I assume you tested?
  2. Did you test across all protocols to make sure there aren't any regressions in any of them? I'd be most concerned about RDP, as the FreeRDP libraries have a tendency to shift around a lot, but would be good to make sure they all work.

necouchman avatar Oct 18 '21 16:10 necouchman

@necouchman I updated the PR description with what I tested, let me know if there's something else I should check (I don't have a VNC server close to me but I can spin one).

xens avatar Oct 18 '21 17:10 xens

Ok I saw an issue, RDPDR is not working with Bullseye as the base image, guacamole-server always fails with the error Cannot create static channel "name": failed to load "guac-common-svc" plugin for FreeRDP, and according to the upstream documentation there must be something weird happening at compilation-time https://guacamole.apache.org/doc/gug/troubleshooting.html I'll dig into it and keep you posted.

xens avatar Oct 20 '21 13:10 xens

So it looks like that FreeRDP searches for plugins in the following path /usr/lib/x86_64-linux-gnu/freerdp2/ instead of /usr/local/guacamole/lib/, despite the LD_LIBRARY_PATHenv variable being correctly set. I've pushed a quick and dirty fix to allow me to continue to test further, I'll try to understand and fix the root cause of this issue. If you have any pointers they are welcome :)

https://github.com/apache/guacamole-server/pull/348/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R161

xens avatar Oct 20 '21 17:10 xens

There is a script that you may need to update : https://github.com/apache/guacamole-server/blob/master/src/guacd-docker/bin/link-freerdp-plugins.sh

jbpaux avatar Oct 22 '21 17:10 jbpaux

Beware that the latest two commits don't follow the convention we use for our commit messages and will need to be updated or squashed into that first commit.

no worries, I converted this PR as DRAFT, I'll rebase + reword when it'll be ready to be merged

xens avatar Nov 20 '21 19:11 xens

As of #388 and #389, the guacd Docker image:

  • Uses the latest Alpine Linux.
  • Automatically builds the latest versions of all protocol libraries at the time the image is built.

So we should be good now, and hopefully will no longer need to bounce back and forth between different versions of Debian and Ubuntu in an effort to get the latest libraries.

Thanks for taking a shot at this, @xens!

mike-jumper avatar Nov 05 '22 15:11 mike-jumper