gobblin icon indicating copy to clipboard operation
gobblin copied to clipboard

[GOBBLIN-2104] Initialize dagProcessingEngine metrics

Open umustafi opened this issue 1 year ago • 2 comments

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

  • [X] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
    • https://issues.apache.org/jira/browse/GOBBLIN-2104

Description

  • [X] Here are some details about my PR, including screenshots (if applicable): This PR adds a common metrics utility class DagProcessingEngineMetrics that is used to trace life cycle of a request from moment it’s received through completion.

DagActionChangeMonitor -> DagManagement -> DagTaskStreamImpl -> MySqlMultiActiveLeaseArbiter -> DagProc

Tests

  • [X] My PR adds the following unit tests OR does not need testing for this extremely good reason: N/A

Commits

  • [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

umustafi avatar Jun 20 '24 16:06 umustafi

TODO: need to add docs/desc

umustafi avatar Jun 28 '24 00:06 umustafi

checks on my fork https://github.com/umustafi/gobblin/pull/31/checks

umustafi avatar Jun 28 '24 23:06 umustafi