gobblin icon indicating copy to clipboard operation
gobblin copied to clipboard

[GOBBLIN-2061] Fix initialization for DagProcessingEngine

Open umustafi opened this issue 1 year ago • 1 comments

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

  • [ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
    • https://issues.apache.org/jira/browse/GOBBLIN-2061

Description

  • [X] Here are some details about my PR, including screenshots (if applicable): Initialize DagProcessingEngine with right parameters  Add DagProcessingEngine to GobblinServiceManager Add logging to DagProcessingEngine instantiation and Threads Fix instantiation of QuartzScheduler for DagActionReminderScheduler Fix DagAction type retrieval from Quartz reminder job detail map

Tests

  • [X] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

umustafi avatar May 03 '24 23:05 umustafi

Checks on my branch https://github.com/umustafi/gobblin/pull/25

umustafi avatar May 03 '24 23:05 umustafi