gobblin icon indicating copy to clipboard operation
gobblin copied to clipboard

[GOBBLIN-2047] Gracefully handle duplicate dagAction entry insertion

Open umustafi opened this issue 1 year ago • 0 comments

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

  • [X] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
    • https://issues.apache.org/jira/browse/GOBBLIN-2047

Description

  • [X] Here are some details about my PR, including screenshots (if applicable):

Tests

  • [X] My PR adds the following unit tests OR does not need testing for this extremely good reason: If a previous dagAction has not been processed already (in the event of service downtime for example), then we want to gracefully handle an attempt to re-add the same action by ignoring the add and completing the MALA lease.
java.lang.RuntimeException: java.io.IOException: Failure adding action for DagAction: DagActionStore.DagAction(flowGroup=FILE_BASED_COPY-mufn, flowName=mufn-holdem_1792467993, flowExecutionId=1713211305981, jobName=, dagActionType=LAUNCH) in table dag_action_store
java.io.IOException: Failure adding action for DagAction: DagActionStore.DagAction(flowGroup=FILE_BASED_COPY-mufn, flowName=mufn-holdem_1792467993, flowExecutionId=1713211305981, jobName=, dagActionType=LAUNCH) in table dag_action_store
java.sql.SQLIntegrityConstraintViolationException: Duplicate entry 'FILE_BASED_COPY-mufn-mufn-holdem_1792467993-1713211305981-LAUNCH' for key 'dag_action_store.PRIMARY'

Commits

  • [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

umustafi avatar Apr 17 '24 18:04 umustafi