gobblin
gobblin copied to clipboard
fix for metric context import
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
- [ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
Tests
- [ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
- Subject is separated from body by a blank line
- Subject is limited to 50 characters
- Subject does not end with a period
- Subject uses the imperative mood ("add", not "adding")
- Body wraps at 72 characters
- Body explains "what" and "why", not "how"
Codecov Report
Merging #3453 (509b5c7) into master (44a7e1a) will decrease coverage by
0.00%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #3453 +/- ##
============================================
- Coverage 46.60% 46.60% -0.01%
- Complexity 10339 10340 +1
============================================
Files 2074 2074
Lines 80958 80958
Branches 9031 9031
============================================
- Hits 37733 37731 -2
- Misses 39749 39754 +5
+ Partials 3476 3473 -3
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...java/org/apache/gobblin/metrics/MetricContext.java | 79.38% <100.00%> (ø) |
|
| .../org/apache/gobblin/metrics/RootMetricContext.java | 73.43% <100.00%> (-6.25%) |
:arrow_down: |
| ...in/java/org/apache/gobblin/cluster/HelixUtils.java | 28.26% <0.00%> (-5.08%) |
:arrow_down: |
| ...a/org/apache/gobblin/cluster/GobblinHelixTask.java | 62.36% <0.00%> (+2.15%) |
:arrow_up: |
| ...lin/restli/throttling/ZookeeperLeaderElection.java | 72.22% <0.00%> (+2.22%) |
:arrow_up: |
| ...t/version/TimestampedDatasetStateStoreVersion.java | 33.33% <0.00%> (+5.55%) |
:arrow_up: |
| .../java/org/apache/gobblin/cluster/SleepingTask.java | 45.45% <0.00%> (+6.06%) |
:arrow_up: |
| ...lin/util/filesystem/FileSystemInstrumentation.java | 100.00% <0.00%> (+7.14%) |
:arrow_up: |
| ...a/org/apache/gobblin/util/limiter/NoopLimiter.java | 60.00% <0.00%> (+20.00%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 44a7e1a...509b5c7. Read the comment docs.