gobblin
gobblin copied to clipboard
[GOBBLIN-1367] Fix PostgresqlExtractor's unnecessary string replacement
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
- [x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1367
Description
- [x] Here are some details about my PR, including screenshots (if applicable):
PostgresqlExtractor fails if the name of schema or table contains the one of its column as substring. This PR fixes it.
Tests
- [x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
- o.a.g.source.jdbc.PostgresqlExtractorTest.testGetHighWatermarkMetadata
- o.a.g.source.jdbc.PostgresqlExtractorTest.testGetCountMetadata
Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
- Subject is separated from body by a blank line
- Subject is limited to 50 characters
- Subject does not end with a period
- Subject uses the imperative mood ("add", not "adding")
- Body wraps at 72 characters
- Body explains "what" and "why", not "how"
Codecov Report
Merging #3209 (07d9511) into master (2fa3553) will decrease coverage by
0.00%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #3209 +/- ##
============================================
- Coverage 46.23% 46.23% -0.01%
- Complexity 9788 9797 +9
============================================
Files 2019 2019
Lines 77439 77504 +65
Branches 8602 8606 +4
============================================
+ Hits 35807 35837 +30
- Misses 38300 38334 +34
- Partials 3332 3333 +1
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 2fa3553...07d9511. Read the comment docs.