gobblin icon indicating copy to clipboard operation
gobblin copied to clipboard

[GOBBLIN-1307] populate topology catalog before starting GobblinServiceJobScheduler

Open arjun4084346 opened this issue 5 years ago • 0 comments

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! @jack-moseley @sv2000 please review

JIRA

  • [X] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
    • https://issues.apache.org/jira/browse/GOBBLIN-1307

Description

  • [x] Here are some details about my PR, including screenshots (if applicable): populate topology catalog before starting GobblinServiceJobScheduler because GobblinServiceJobScheduler needs to compile flow specs and compilation needs topologies to be loaded in memory

Tests

  • [x] My PR adds the following unit tests OR does not need testing for this extremely good reason: trivial changes

Commits

  • [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

arjun4084346 avatar Oct 30 '20 23:10 arjun4084346