fury icon indicating copy to clipboard operation
fury copied to clipboard

feat(C++): Enable Windows C++ CI and fix some compilation errors

Open LiangliangSui opened this issue 2 years ago • 5 comments

Use windows-2022 in CI and fix some C++ compilation errors in windows.

LiangliangSui avatar Jan 10 '24 12:01 LiangliangSui

Windows C++ CI has passed. PTAL!

LiangliangSui avatar Jan 10 '24 12:01 LiangliangSui

Generally speaking, if supporting msvc cl makes the maintainability of the code worse, the code quality is significantly reduced, or the previous code structure has unreasonable changes, I would be inclined not to support msvc.

Users can use better compilers such as clang (or clang-cl with msvc) under windows.

PragmaTwice avatar Jan 10 '24 15:01 PragmaTwice

msvc's support for C++ is different from gcc in many details (it will produce many strange compilation errors, you can try it locally). If you think that adapting msvc will reduce the maintainability of the code, we can completely ignore the windows compilation C++ without having to spend some unrewarded time. @PragmaTwice

LiangliangSui avatar Jan 10 '24 15:01 LiangliangSui

I will look into the support of msvc and try it on my local these days, and provide my updates here.

PragmaTwice avatar Jan 10 '24 15:01 PragmaTwice

I look forward to your ideas and hope to learn from you :muscle:

LiangliangSui avatar Jan 10 '24 15:01 LiangliangSui