fury icon indicating copy to clipboard operation
fury copied to clipboard

Consider to rewrite shell scripts in Python

Open PragmaTwice opened this issue 2 years ago • 5 comments

TBH these CI scripts are hard to maintain (especially considering the difference between bash and zsh, and the difficulty to execute them on windows), we need a more structure language like python to make them readable and maintanable.

https://github.com/apache/incubator-fury/tree/main/ci

PragmaTwice avatar Jan 03 '24 15:01 PragmaTwice

I totally agree with this, it can mask the differences in script syntax (e.g. windows script syntax is very unfriendly), and it is easier to write and code readable.

LiangliangSui avatar Jan 03 '24 15:01 LiangliangSui

Sounds good to me, but rewriting those scripts into python is not an easy work, and most scripts are used by CI only. I suggest we start from rewriting the scripts used by contributors everyday.

chaokunyang avatar Jan 03 '24 16:01 chaokunyang

This remind me of PyTorch. When you filing an issue, you can execute a python script from PyTorch, which can collect system information as much as it can, and print it. Then you can paste such information into the issue for trouble shooting

chaokunyang avatar Jan 03 '24 16:01 chaokunyang

So can we start by rewriting the C++ CI Build script in Windows? such as run_ci.py

LiangliangSui avatar Jan 04 '24 02:01 LiangliangSui

Yep, we can start from rewriting the C++ CI Build script in Windows

chaokunyang avatar Jan 04 '24 03:01 chaokunyang