apache
[FLINK-36571][web] Fix issue to allow Busy and Backpressure numbers o…
…n Flink dashboard
What is the purpose of the change
Fix bug so that non-zero numbers of Busy / Backpressure can be shown on Flink dashboard
Brief change log
- Add check for
!!valueto convert value to boolean - Add check before setting
dataSkewPercentage
Verifying this change
- This change is a trivial rework / code cleanup without any test coverage.
- Manually checked on a job running locally, that non-zero Busy % can be seen.
Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
@Public(Evolving):no - The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
CI report:
- b793e1d156129d7026dd2257340372db0162ca15 Azure: FAILURE
Bot commands
The @flinkbot bot supports the following commands:-
@flinkbot run azurere-run the last Azure build
Thanks for fixing it! I was wondering what has broken that.
@xintongsong @Laffery , can one of you take a look at this? It was caused by a change that you committed a while back and I don't know enough about JS/TS to do a proper review :(
@hlteoh37 if this won't get reviewed soon, please remind me I will merge it as is trusting your manual tests.
CI seems to be failing because of editing a wiki -.- 99.9% sure it's not related to this change!
CI seems to be failing because of editing a wiki -.- 99.9% sure it's not related to this change!
That has been fixed on master, so rebasing would have fixed it. But anyway, I'm merging it as it is :) Thanks for the fix and thanks @Laffery for the review!