flink icon indicating copy to clipboard operation
flink copied to clipboard

[hotfix][connector/pulsar][docs] Update atEventTime to atPublishTime in JavaDoc

Open a49a opened this issue 3 years ago • 4 comments

What is the purpose of the change

The atEventTime is deprecated, We need update JavaDoc to atPublishTime

Brief change log

  • Update atEventTime to atPublishTime in JavaDoc of PulsarSourceBuilder class

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (no)

a49a avatar May 20 '22 10:05 a49a

CI report:

  • 0f4846beac1d300f45e2af1aacd43e6059871ebd Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar May 20 '22 10:05 flinkbot

@MartijnVisser Please review it, thanks a lot.

a49a avatar Jun 08 '22 07:06 a49a

The connector maintainer @syhily says "This is ok". Could we merge it @MartijnVisser ? Thanks a lot.

a49a avatar Jun 21 '22 06:06 a49a

The connector maintainer @syhily says "This is ok". Could we merge it @MartijnVisser ? Thanks a lot.

If he approves the PR, yes

MartijnVisser avatar Aug 03 '22 13:08 MartijnVisser