flink-ml icon indicating copy to clipboard operation
flink-ml copied to clipboard

[FLINK-29323] Refine Transformer for VectorAssembler

Open weibozhao opened this issue 3 years ago • 1 comments

What is the purpose of the change

Refine Transformer for VectorAssembler in Flink ML.

Brief change log

Added a new API(setSizes()) for VectorAssembler transformer.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no) The public API, i.e., is any changed class annotated with @public(Evolving): (yes) Does this pull request introduce a new feature? (yes) If yes, how is the feature documented? (Java doc)

weibozhao avatar Sep 16 '22 10:09 weibozhao

Hi @weibozhao , could you please refine the description and JavaDocs of this PR, illustrating why do we need to add the size parameter to VectorAssembler? What additional functionalities has this parameter support, and how is this parameter compatible with the original public API?

yunfengzhou-hub avatar Sep 19 '22 01:09 yunfengzhou-hub

Thanks for the update. LGTM.

zhipeng93 avatar Nov 08 '22 09:11 zhipeng93