flink-agents icon indicating copy to clipboard operation
flink-agents copied to clipboard
Published 1 month ago • verified publisher icon apache

[hotfix] Fix the type loss issue in the deserialization of ResourceProvider

Open GreatEugenius opened this issue 2 months ago • 4 comments

Purpose of change

Fix the type loss issue in the deserialization of ResourceProvider and correct the improper use of the descriptor.

Tests

ut

API

Documentation

The commit already includes the changes to the Docs.

  • [ ] doc-needed
  • [x] doc-not-needed

GreatEugenius avatar Nov 27 '25 07:11 GreatEugenius

Hi, @Sxnan and @wenjin272, please take a look at this PR. Thank you.

GreatEugenius avatar Nov 27 '25 07:11 GreatEugenius

What result will the type loss cause?

wenjin272 avatar Nov 27 '25 10:11 wenjin272

What result will the type loss cause?

Currently, it does not affect user usage because a forced type conversion has been performed on the Python side through the BaseModel. However, to support cross-language features, we need to address this issue first.

GreatEugenius avatar Nov 27 '25 11:11 GreatEugenius

LGTM

wenjin272 avatar Nov 28 '25 06:11 wenjin272

Hi @Sxnan, thank you for the review! I have updated this PR; please review it again.

GreatEugenius avatar Dec 08 '25 09:12 GreatEugenius