eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[Unit Test] Add unit test for eventmesh-connector-file module

Open VishalMCF opened this issue 2 years ago • 6 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Read the unit testing guidelines

  • [X] I have read.

Unit test request

Add unit test for the FileSourceConnector and FileSinkConnector classes.

Describe the unit tests you want to do

Add unit test for the FileSourceConnector and FileSinkConnector classes.

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

VishalMCF avatar Dec 13 '23 14:12 VishalMCF

Can I submit a pr for this? @VishalMCF

Divyansh200102 avatar Jan 18 '24 00:01 Divyansh200102

@Divyansh200102 Sure please go ahead. But make sure that the core logic in File Connector has been implemented. Last time I checked there were issues in the PR. Not sure if they have been merged or not.

VishalMCF avatar Jan 18 '24 07:01 VishalMCF

@Divyansh200102 Sure please go ahead. But make sure that the core logic in File Connector has been implemented. Last time I checked there were issues in the PR. Not sure if they have been merged or not.

@Divyansh200102 You can add unit test for FileSinkConnector freely. The unit test for FileSourceConnector is being added by other developer.

pandaapo avatar Jan 19 '24 13:01 pandaapo

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.

github-actions[bot] avatar Apr 18 '24 18:04 github-actions[bot]

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.

github-actions[bot] avatar Jul 18 '24 18:07 github-actions[bot]