echarts icon indicating copy to clipboard operation
echarts copied to clipboard

Fix #18754 - [Feature] Adds sampling support to dataZoomSlider

Open biggates opened this issue 2 years ago • 1 comments

Brief Information

This pull request is in the type of:

  • [ ] bug fixing
  • [x] new feature
  • [ ] others

What does this PR do?

  • Adds sampling support in dataZoom

Fixed issues

  • #18754

Details

Before: What was the problem?

the sampling method in dataZoomSlider is not the same as in series. In rare cases (lots of fast changing points), it may result in incorrect shape.

图片

After: How does it behave after the fixing?

called the same processing function in dataZoomSlider as in dataSample(), and will fallback to the old implementation if sampling is not applicable.

图片

Document Info

One of the following should be checked.

  • [ ] This PR doesn't relate to document changes
  • [ ] The document should be updated later
  • [x] The document changes have been made in apache/echarts-doc#350

This PR will add an additional optional configuration sampling in dataZoom so an update is required.

Misc

Related test cases or examples to use the new APIs

  • test case: dataZoom-sampling.html

Others

Merging options

  • [x] Please squash the commits into a single one when merging.

Other information

biggates avatar Jun 15 '23 11:06 biggates

Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

echarts-bot[bot] avatar Jun 15 '23 11:06 echarts-bot[bot]