fix(dataZoom): render data not equally distributed. close #16924 #15921

[andrearoota]

Brief Information

This pull request is in the type of:

• [x] bug fixing
• [ ] new feature
• [ ] others

What does this PR do?

Fix render data shadow line with data not equally distributed in time axis

Fixed issues

#16924 #15921 #16980

Details

Before: What was the problem?

Data shadow line in bottom dataZoom does not match with serie line on graph

After: How is it fixed in this PR?

If type of axis is set to "time", scale the original axis data range to dataZoom axis range I used this mathematical formula

Misc

• [ ] The API has been changed (apache/echarts-doc#xxx).
• [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

• [x] Please squash the commits into a single one when merging.

Other information

[echarts-bot[bot]]

Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

[Ovilia]

I'm also fixing related problems at #17311 . I will check the logic more carefully later. Thanks for your contribution!

[piotrbubelE]

Hello! Is there a plan to merge this PR anytime soon? It also enables workaround for bug with axis.min and axis.max on dataShadow

[pchrzaszczewski]

I am also waiting for this fix. What are your plans?

[kamilapolewczykatos]

Merge would be great. I need this fix for my app.

[zsamotsil]

It would be great to ship it. Need also this fix in my application.

[piotrbubelE]

Here is issue that can use workaround from this PR: https://github.com/apache/echarts/issues/19957

[grzesikj]

When will this be available for use? Without this I cannot use data zoom slider in my project.

[Bernard-code]

I really could use this fix. When will this be available to use?

[grzesikj]

Add it, please.

[grzesikj]

When can you add it?

[noahhai]

Fix PR pending for two years 😭

[pchrzaszczewski]

Should we spam somehow this topic in anticipation of the answer? Echarts team give us some answer.

I give you some possible options. I hope it will help you to respond to the community:

• "we are already working on it, fix will be available in... insert date here",
• "it was solved differently, here you have the solution...",
• "we don't care",
• "we don't give a shit",
• "go to hell"

Choose wisely. We will know what to do next... :disappointed:

[noahhai]

@pchrzaszczewski Woah easy there. I get the frustration though.

I am going to create a pnpm patch based on the fixes in the PR and just pin the echarts version in my dependencies. Not great, but I assume at some point it will get fixed.

[andrearoota]

@pchrzaszczewski Woah easy there. I get the frustration though.

I am going to create a pnpm patch based on the fixes in the PR and just pin the echarts version in my dependencies. Not great, but I assume at some point it will get fixed.

Does my code still work in the current version? I am willing to improve it and update it if necessary

[pchrzaszczewski]

@pchrzaszczewski Woah easy there. I get the frustration though.

I am going to create a pnpm patch based on the fixes in the PR and just pin the echarts version in my dependencies. Not great, but I assume at some point it will get fixed.

@noahhai I'm grateful that you responded. We can see that something is happening ;)

I've been patient for 2 years :muscle: It is always better to at least know if there is a plan or not. I'm keeping my fingers crossed and cheering that the day will finally come... :crossed_fingers:

[grzesikj]

I'm still waiting

[alinscodes]

Can we just deploy this pleasE?

[jteez]

Still hoping for this fix too!